From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757358AbdJPUW3 (ORCPT ); Mon, 16 Oct 2017 16:22:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757324AbdJPUW1 (ORCPT ); Mon, 16 Oct 2017 16:22:27 -0400 Date: Mon, 16 Oct 2017 21:22:23 +0100 (WEST) Message-Id: <20171016.212223.777323721927998324.davem@davemloft.net> To: boris.ostrovsky@oracle.com Cc: wei.liu2@citrix.com, mgamal@redhat.com, netdev@vger.kernel.org, xen-devel@lists.xenproject.org, paul.durrant@citrix.com, linux-kernel@vger.kernel.org, vkuznets@redhat.com, otubo@redhat.com, cavery@redhat.com, cheshi@redhat.com, jgross@suse.com Subject: Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values From: David Miller In-Reply-To: <3da3d5ae-c2cb-380e-368d-a90432608cf1@oracle.com> References: <1508160032-21689-1-git-send-email-mgamal@redhat.com> <20171016150522.nebui653rkjove7r@citrix.com> <3da3d5ae-c2cb-380e-368d-a90432608cf1@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Oct 2017 13:22:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Boris Ostrovsky Date: Mon, 16 Oct 2017 16:19:07 -0400 > On 10/16/2017 11:05 AM, Wei Liu wrote: >> On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: >>> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} >>> drivers use a minimum value of 0. >>> >>> When set MTU to 0~67 with xen_net{front|back} driver, the network >>> will become unreachable immediately, the guest can no longer be pinged. >>> >>> xen_net{front|back} should not allow the user to set this value which causes >>> network problems. >>> >>> Reported-by: Chen Shi >>> Signed-off-by: Mohammed Gamal >> Acked-by: Wei Liu >> >> CC netfront maintainers > > > Reviewed-by: Boris Ostrovsky > > I can take it via Xen tree unless there are objections. No problem on my end.