From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010AbdJPJOJ (ORCPT ); Mon, 16 Oct 2017 05:14:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48744 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750914AbdJPJOI (ORCPT ); Mon, 16 Oct 2017 05:14:08 -0400 Date: Mon, 16 Oct 2017 11:13:58 +0200 From: Martin Schwidefsky To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com Subject: Re: [RFC 13/19] s390/zcrypt: validate control domain assignment In-Reply-To: <1507916344-3896-14-git-send-email-akrowiak@linux.vnet.ibm.com> References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1507916344-3896-14-git-send-email-akrowiak@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17101609-0020-0000-0000-000003C12C37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101609-0021-0000-0000-000042556505 Message-Id: <20171016111358.12248624@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017 13:38:58 -0400 Tony Krowiak wrote: > The AP control domain being assigned to the mediated > matrix driver must be assigned to the LPAR. > > Signed-off-by: Tony Krowiak > --- > drivers/s390/crypto/vfio_ap_matrix_ops.c | 33 ++++++++++++++++++++++++++++++ > 1 files changed, 33 insertions(+), 0 deletions(-) > > diff --git a/drivers/s390/crypto/vfio_ap_matrix_ops.c b/drivers/s390/crypto/vfio_ap_matrix_ops.c > index 2387916..10a006c 100644 > --- a/drivers/s390/crypto/vfio_ap_matrix_ops.c > +++ b/drivers/s390/crypto/vfio_ap_matrix_ops.c > @@ -469,12 +469,41 @@ static ssize_t ap_matrix_domains_show(struct device *dev, > static DEVICE_ATTR(domains, 0644, ap_matrix_domains_show, > NULL); > > +static int > +ap_matrix_validate_control_domains(struct ap_matrix_mdev *matrix_mdev, > + unsigned long id) > +{ > + int ret; > + struct ap_config_info config; > + > + memset(&config, 0, sizeof(config)); > + > + ret = ap_query_configuration(&config); > + if (ret == -EOPNOTSUPP) > + return 0; > + > + if (ret) { > + pr_err("%s: query AP configuration failed with rc %d", > + VFIO_AP_MATRIX_MODULE_NAME, ret); > + return ret; > + } > + > + if (!test_bit_inv(id, (unsigned long *)config.adm)) { > + pr_err("%s: control domain %04lx is not installed on the lpar", > + VFIO_AP_MATRIX_MODULE_NAME, id); > + return -ENODEV; > + } > + > + return 0; > +} > + > static ssize_t ap_matrix_control_domain_assign(struct device *dev, > struct device_attribute *attr, > const char *buf, size_t count) > { > int ret; > unsigned int id; > + > struct mdev_device *mdev = mdev_from_dev(dev); > struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); > > @@ -482,6 +511,10 @@ static ssize_t ap_matrix_control_domain_assign(struct device *dev, > if (ret) > return ret; > > + ret = ap_matrix_validate_control_domains(matrix_mdev, id); > + if (ret) > + return ret; > + > set_bit_inv((unsigned long)id, > (unsigned long *)matrix_mdev->masks.adm); > Is there a specific reason why patch #13 is separate from patch #12 that introduces the domain assignment? The assignment code does not make much sense with the check if the domain is assigned to the LPAR, no? -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.