From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbdJPJZV (ORCPT ); Mon, 16 Oct 2017 05:25:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44400 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbdJPJZT (ORCPT ); Mon, 16 Oct 2017 05:25:19 -0400 Date: Mon, 16 Oct 2017 11:25:10 +0200 From: Martin Schwidefsky To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com Subject: Re: [RFC 19/19] s390/facilities: enable AP facilities needed by guest In-Reply-To: <1507916344-3896-20-git-send-email-akrowiak@linux.vnet.ibm.com> References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1507916344-3896-20-git-send-email-akrowiak@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17101609-0012-0000-0000-000005822FC7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101609-0013-0000-0000-000018FC67F6 Message-Id: <20171016112510.39e9c330@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017 13:39:04 -0400 Tony Krowiak wrote: > Sets up the following facilities bits to enable the specified AP > facilities for the guest VM: > * STFLE.12: Enables the AP Query Configuration Information > facility. The AP bus running in the guest uses > the information returned from this instruction > to configure AP adapters and domains for the > guest machine. > * STFLE.15: Indicates the AP facilities test is available. > The AP bus running in the guest uses the > information. > > Signed-off-by: Tony Krowiak > --- > arch/s390/tools/gen_facilities.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/s390/tools/gen_facilities.c b/arch/s390/tools/gen_facilities.c > index 70dd8f1..eeaa7db 100644 > --- a/arch/s390/tools/gen_facilities.c > +++ b/arch/s390/tools/gen_facilities.c > @@ -74,8 +74,10 @@ struct facility_def { > 8, /* enhanced-DAT 1 */ > 9, /* sense-running-status */ > 10, /* conditional sske */ > + 12, /* AP query configuration */ > 13, /* ipte-range */ > 14, /* nonquiescing key-setting */ > + 15, /* AP special-command facility */ > 73, /* transactional execution */ > 75, /* access-exception-fetch/store indication */ > 76, /* msa extension 3 */ With this all KVM guests will always have the AP instructions available, no? In principles I like this approach, but it differs from the way z/VM does things, there the guest will get an exception if it tries to execute an AP instruction if there are no AP devices assigned to the guest. I wonder if there is a reason why z/VM does it the way it does. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.