From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbdJPJ2H (ORCPT ); Mon, 16 Oct 2017 05:28:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46990 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdJPJ2F (ORCPT ); Mon, 16 Oct 2017 05:28:05 -0400 Date: Mon, 16 Oct 2017 11:27:55 +0200 From: Martin Schwidefsky To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com Subject: Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters In-Reply-To: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17101609-0012-0000-0000-000005822FF8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101609-0013-0000-0000-000018FC682D Message-Id: <20171016112755.4d6b3ea1@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017 13:38:45 -0400 Tony Krowiak wrote: > Tony Krowiak (19): > KVM: s390: SIE considerations for AP Queue virtualization > KVM: s390: refactor crypto initialization > s390/zcrypt: new AP matrix bus > s390/zcrypt: create an AP matrix device on the AP matrix bus > s390/zcrypt: base implementation of AP matrix device driver > s390/zcrypt: register matrix device with VFIO mediated device > framework > KVM: s390: introduce AP matrix configuration interface > s390/zcrypt: support for assigning adapters to matrix mdev > s390/zcrypt: validate adapter assignment > s390/zcrypt: sysfs interfaces supporting AP domain assignment > s390/zcrypt: validate domain assignment > s390/zcrypt: sysfs support for control domain assignment > s390/zcrypt: validate control domain assignment > KVM: s390: Connect the AP mediated matrix device to KVM > s390/zcrypt: introduce ioctl access to VFIO AP Matrix driver > KVM: s390: interface to configure KVM guest's AP matrix > KVM: s390: validate input to AP matrix config interface > KVM: s390: New ioctl to configure KVM guest's AP matrix > s390/facilities: enable AP facilities needed by guest Overall I am quite happy with the patches, only minor things I would like to see improved. We have to agree how we want to approach the upstream process between my s390/linux tree and the s390/kvm tree. Probably a tip branch again for the both tress to pull from. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.