From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: icenowy@aosc.io
Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Icenowy Zheng <icenowy@aosc.xyz>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40
Date: Mon, 16 Oct 2017 14:06:33 +0200 [thread overview]
Message-ID: <20171016120633.6jof6wvsre27rxhv@flea.lan> (raw)
In-Reply-To: <7ee77556174b84846a59d57525ec1cb9@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Mon, Oct 16, 2017 at 05:39:58PM +0800, icenowy@aosc.io wrote:
> 在 2017-10-16 17:32，Maxime Ripard 写道：
> > On Tue, Oct 10, 2017 at 07:24:28AM +0800, Icenowy Zheng wrote:
> > > >> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> > > >> + clocks = <&ccu CLK_BUS_OHCI1>,
> > > >> + <&ccu CLK_BUS_EHCI1>,
> > > >> + <&ccu CLK_USB_OHCI1>;
> > > >> + resets = <&ccu RST_BUS_OHCI1>,
> > > >> + <&ccu RST_BUS_EHCI1>;
> > > >
> > > >Why do you need to take the OHCI resources too?
> > >
> > > AW's strange design -- without OHCI resources taken EHCI
> > > won't work.
> >
> > How has this been tested?
>
> As EHCI is probed before OHCI, this behavior is easy to
> appear if the OHCI resources are removed.
And what is "this behaviour" exactly?
What have you tested, what device did you connect, what is the outcome
that isn't something you expected, etc.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-10-16 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 4:29 [PATCH 0/6] Allwinner R40 USB host support Icenowy Zheng
2017-10-08 4:29 ` [PATCH 1/6] phy: sun4i-usb: add support for R40 USB PHY Icenowy Zheng
2017-10-09 20:58 ` Maxime Ripard
2017-10-18 11:39 ` Kishon Vijay Abraham I
2017-10-18 11:42 ` Maxime Ripard
2017-10-18 11:46 ` Kishon Vijay Abraham I
2017-12-30 11:38 ` Icenowy Zheng
2018-01-03 8:40 ` Kishon Vijay Abraham I
2017-10-13 19:29 ` Rob Herring
2017-10-08 4:29 ` [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40 Icenowy Zheng
2017-10-09 21:03 ` Maxime Ripard
2017-10-09 23:24 ` Icenowy Zheng
2017-10-16 9:32 ` Maxime Ripard
2017-10-16 9:39 ` icenowy
2017-10-16 12:06 ` Maxime Ripard [this message]
2017-10-18 12:21 ` icenowy
2017-10-08 4:29 ` [PATCH 3/6] ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra Icenowy Zheng
2017-10-09 21:04 ` Maxime Ripard
2017-10-09 23:25 ` Icenowy Zheng
2017-10-10 2:25 ` [linux-sunxi] " Chen-Yu Tsai
2017-10-10 9:39 ` Maxime Ripard
2017-10-08 4:29 ` [PATCH 4/6] ARM: sun8i: v40: add 5V regulator for Banana Pi M2 Berry Icenowy Zheng
2017-10-08 4:29 ` [PATCH 5/6] ARM: sun8i: r40: enable USB host for Banana Pi M2 Ultra Icenowy Zheng
2017-10-08 4:29 ` [PATCH 6/6] ARM: sun8i: v40: enable USB host ports for Banana Pi M2 Berry Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016120633.6jof6wvsre27rxhv@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=icenowy@aosc.xyz \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®