From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: icenowy@aosc.io
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section
Date: Mon, 16 Oct 2017 14:09:12 +0200 [thread overview]
Message-ID: <20171016120912.lxu7rikhffxsu5o4@flea.lan> (raw)
In-Reply-To: <d62ac8b8ff9073b886ceaa9ce54e6903@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Mon, Oct 16, 2017 at 05:41:10PM +0800, icenowy@aosc.io wrote:
> 在 2017-10-16 17:11，Maxime Ripard 写道：
> > On Sat, Oct 14, 2017 at 08:29:24PM +0800, Icenowy Zheng wrote:
> > > A64's Display Engine 2.0 needs a section of SRAM (SRAM C) to be
> > > claimed.
> >
> > Why?
>
> Allwinner didn't document this, but if the SRAM is not claimed, the
> DE2 MMIO zone is totally not accessible.
Not accessible how? It generates an abort when you access it? It
returns 0?
> It seems that Allwinner uses the SRAM C in the DE2 internally.
Then shouldn't it be tied to all the DE2 devices then? So mixers
too. Either way, this should be mentionned in your commit logs. How
you're fixing things is much less interesting than why you're doing
them. You can tell how you're doing them from your code already.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-10-16 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 12:29 Icenowy Zheng
2017-10-14 12:29 ` [PATCH 2/2] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU Icenowy Zheng
2017-10-16 9:11 ` [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section Maxime Ripard
2017-10-16 9:41 ` icenowy
2017-10-16 12:09 ` Maxime Ripard [this message]
2017-10-27 14:33 ` icenowy
2017-10-27 15:13 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016120912.lxu7rikhffxsu5o4@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®