From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756117AbdJPQVi (ORCPT ); Mon, 16 Oct 2017 12:21:38 -0400 Received: from mail.skyhub.de ([5.9.137.197]:58132 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbdJPQVg (ORCPT ); Mon, 16 Oct 2017 12:21:36 -0400 Date: Mon, 16 Oct 2017 18:21:18 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , linux-kernel@vger.kernel.org Subject: Re: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support Message-ID: <20171016162118.i2n34wrfiaqytr5v@pd.tnic> References: <20171016153423.2980-1-brijesh.singh@amd.com> <20171016153423.2980-3-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171016153423.2980-3-brijesh.singh@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 10:34:08AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Provide support for Secure Encrypted Virtualization (SEV). This initial > support defines a flag that is used by the kernel to determine if it is > running with SEV active. ... > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index 16c5f37933a2..af7f733f6f31 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -42,6 +42,8 @@ static char sme_cmdline_off[] __initdata = "off"; > u64 sme_me_mask __section(.data) = 0; > EXPORT_SYMBOL_GPL(sme_me_mask); > > +static bool sev_enabled __section(.data) = false; You need to run a patch through checkpatch everytime you change it - sometimes the warning makes sense, like in this case: ERROR: do not initialise statics to false #73: FILE: arch/x86/mm/mem_encrypt.c:45: +static bool sev_enabled __section(.data) = false; Please add checkpatch to a script which you run before committing. Or something to that effect. In any case, you should automate it so that you don't forget. Thx. P.S., just send a fixed version as a reply to this message. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.