From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933659AbdJQGeb (ORCPT ); Tue, 17 Oct 2017 02:34:31 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:54680 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933642AbdJQGe3 (ORCPT ); Tue, 17 Oct 2017 02:34:29 -0400 X-Google-Smtp-Source: AOwi7QC7owxbB0mClJt3LTRtCICpkI8M69ZaXTC5z8yqAgp/y8j8A4v5zhn/vc7u0ecntWGNqQioKg== From: Nick Desaulniers To: tj@kernel.org Cc: Nick Desaulniers , Li Zefan , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cgroup: reorder flexible array members of struct cgroup_root Date: Mon, 16 Oct 2017 23:33:21 -0700 Message-Id: <20171017063322.11455-1-nick.desaulniers@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the following warning is observed: ./include/linux/cgroup-defs.h:391:16: warning: field 'cgrp' with variable sized type 'struct cgroup' not at the end of a struct or class is a GNU extension [-Wgnu-variable-sized-type-not-at-end] struct cgroup cgrp; ^ Flexible array members are a C99 feature, but must be the last member of a struct. Structs with flexible members composed in other structs must also be the final members, unless using GNU C extensions. struct cgroup_root's member cgrp is a struct cgroup, struct cgroup's member ancestor_ids is a flexible member. Signed-off-by: Nick Desaulniers --- Alternatively, we could: * Not use flexible array members. The flexible array members and allocation strategy, added in commit b11cfb5807e30 mentions the hot path, so this is likely not an option? * Disable this warning for HOSTCC==clang. I'd rather not, since there's nothing really requiring the use of this particular GNU C extension here, or specific location of the member cgrp within struct cgroup_root AFAICT. include/linux/cgroup-defs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index ade4a78a54c2..2ef256932bf3 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -387,9 +387,6 @@ struct cgroup_root { /* Unique id for this hierarchy. */ int hierarchy_id; - /* The root cgroup. Root is destroyed on its release. */ - struct cgroup cgrp; - /* for cgrp->ancestor_ids[0] */ int cgrp_ancestor_id_storage; @@ -410,6 +407,9 @@ struct cgroup_root { /* The name for this hierarchy - may be empty */ char name[MAX_CGROUP_ROOT_NAMELEN]; + + /* The root cgroup. Root is destroyed on its release. */ + struct cgroup cgrp; }; /* -- 2.11.0