From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759017AbdJQHRE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 03:17:04 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:53038 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752373AbdJQHRC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 03:17:02 -0400
X-Google-Smtp-Source: ABhQp+QE6bmLOLKVV2ZDwDB6Dm85XZRud/piTc9K0X8+5RKVSpHmECeedFZyMPLwbSBEl24gJhZwNg==
Date: Tue, 17 Oct 2017 08:16:59 +0100
From: Javi Merino <javi.merino@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Eduardo Valentin <edubezval@gmail.com>
Subject: Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when
 not in use
Message-ID: <20171017071659.57q4tcrg2mrochjn@tesla>
References: <20171013101941.0f371042@gandalf.local.home>
 <20171013102309.2c4ef81a@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171013102309.2c4ef81a@gandalf.local.home>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 13, 2017 at 10:23:09AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> As trace events when defined create data structures and functions to
> process them, defining trace events when not using them is a waste of
> memory.
> 
> The trace events thermal_power_cpu_get_power and
> thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set.
> Make those events only defined when that is set as well.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Acked-by: Javi Merino <javi.merino@kernel.org>

> ---
> Index: linux-trace.git/include/trace/events/thermal.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/thermal.h
> +++ linux-trace.git/include/trace/events/thermal.h
> @@ -90,6 +90,7 @@ TRACE_EVENT(thermal_zone_trip,
>  		show_tzt_type(__entry->trip_type))
>  );
>  
> +#ifdef CONFIG_CPU_THERMAL
>  TRACE_EVENT(thermal_power_cpu_get_power,
>  	TP_PROTO(const struct cpumask *cpus, unsigned long freq, u32 *load,
>  		size_t load_len, u32 dynamic_power, u32 static_power),
> @@ -147,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
>  		__get_bitmask(cpumask), __entry->freq, __entry->cdev_state,
>  		__entry->power)
>  );
> +#endif /* CONFIG_CPU_THERMAL */
>  
>  #ifdef CONFIG_DEVFREQ_THERMAL
>  TRACE_EVENT(thermal_power_devfreq_get_power,