From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934521AbdJQIkK (ORCPT ); Tue, 17 Oct 2017 04:40:10 -0400 Received: from mail-sn1nam02on0078.outbound.protection.outlook.com ([104.47.36.78]:52000 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754234AbdJQIkG (ORCPT ); Tue, 17 Oct 2017 04:40:06 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sergey.matyukevich.os@quantenna.com; Date: Tue, 17 Oct 2017 11:39:53 +0300 From: Sergey Matyukevich To: Kees Cook Cc: Kalle Valo , Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Kamlesh Rath , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wireless: qtnfmac: Convert timers to use timer_setup() Message-ID: <20171017083951.c56333pxizupnvym@bars> Mail-Followup-To: Kees Cook , Kalle Valo , Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Kamlesh Rath , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171016233622.GA101550@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016233622.GA101550@beast> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [195.182.157.78] X-ClientProxiedBy: AM5PR0402CA0011.eurprd04.prod.outlook.com (10.175.37.21) To SN1PR05MB1933.namprd05.prod.outlook.com (10.162.132.11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd2ee994-4750-4eee-fb8f-08d5153aa986 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR05MB1933; X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB1933;3:CFVUJdnslsqjf36OuskFWBNFqYcAtzWXKUeksxrUm3XibluA2gwJxrg1oG1slCeV5G01Y4E9NApjbsdN6ZM0PeVAu/HPRD3ZV5Ud6Z6Ks0JOK59RBpK48+IBfgO8q3UYmSnyfod6Yj/GsGjJmqCPpbUloXpUiXiemN7ADZrPcFchRhgt3TollfMmVnESnCML0ZEK4Kevvzo79noPVODDNV3dBfc2v5y7kcMRSfbocS7E/jC+vgYEsRAuO7J2Isa0;25:r38fgyzn5+Hfif4pDmUJKwUspEiRa/Qn9+LOyIzgXDa8axAyDBwL64YEWfFJ/1MLXZl+zg0SoUARYVmP7zY5FIek2b7A6WaAt1WGHvgh1pzrg0IvOShhNcNQunJOzhtvd6UWn9OnS6szWAY9AKJCC80cq/m126EYOk4s0HUJiagizM7afHJkYF2VdVrkvwiB61wtxOPLuEC6tvdT32bYNQ7LuX8J3mbr8/CIjWdLmodP54jeeIW2C6RePaHAUfEN5jZR9j5dSIgodq93mbg8ugQTQq0jxKODXJ3G2NflvqXcV03AmU8LE6wiycwGrsLGh4UGd9X401cRGjZPnpPPHw==;31:660fYBgv+aWWaDZJdoUKrofNh3msUfzOGsgoZgShtkjRgiN/c2Am/HWyCD2j9/NNvwQDmsX5dBB48jbbX3em8kVSQorfNqU25RnGvRcUrIRUdBQeYpHgC9enWniDuSgW6536k/BWyqacAemDznunpTBuOy0FeelAikVxC9sKv36cQS7l9NoZPMVjGRp4A7rbw9/4561f4GQBdTq7yWxkTwvTk1k/gRlqDqwlqbIxxKs= X-MS-TrafficTypeDiagnostic: SN1PR05MB1933: X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB1933;20:eK+P+DlO4WXu4K4XgXy+xeZwqeXq44dRlchrnA+X8m3soMSjXHA/bB3QeYkS7iY+/VTEdjlB6nw8PWz/Z8PunA3HJNqfQGWZWeMHS1gTprKnorv6UeKMlMAJ56RMfzGktkyGjHEzc8U193Yj0DAn16uu0JF+Lc8kKNT07OW0yRZ1+zZF2wghzlCZodBVClzz9mp8CubBkVTWUdQBWRxf3HESutP8atHgjrMg19d0k0s1fg6cHhYknHcUu1u1LEway24e9rsiS1NEWD0J1uTi7HP1zbldC+wkqcjkW/3CVG9ymzA5zCuaasvTlioTXD60ULVQ/KmFB70ACnGGVdOifdGGFWiBrrvBcc6ixUFnwzAE8+adpTntvuayEUGVrG89mK4G069Nill57++f8gZH5ZDMJIntI7jw8+3WgL2s9WD2j+QnNpzNi5GFat6lIHXg7WNqUmX+viHI5T1An2EGMsUI9T2meLfcZt7E0E+d9ACwzHE0zU5beZGuQUwP1+3A;4:cAG6zLUyNVz2jLNSnoK/6pl9KrkKcHM/t4OOxtUlyYr019HyblGvc0lBft39+uwGFR+3Icwq3x7xt6DccsHKzc5HfhG6UW8cvh49X0cOBdcyo3cR9YxLFIvMHebGpnnvhIiLYNuQ/W3BgLRI58txamIy9S+sH+bEeM26fbgzTcIWUmAPFa/W1BilMyeyjHDZGWrKTXLKhwnxM0L9BqbL1gMsVK/zW/sElDr2iIvZxAs5yDZz+aKqMkLXHaJKkZbIOYwiUEn+ZaN7TptqNnGkYbFis4F76ulxL2Zi4/d8Mqs= X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR05MB1933;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR05MB1933; X-Forefront-PRVS: 04631F8F77 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39830400002)(376002)(346002)(189002)(199003)(3846002)(86362001)(6116002)(23726003)(106356001)(1076002)(7736002)(105586002)(229853002)(6666003)(305945005)(53936002)(66066001)(2906002)(6496005)(6246003)(4326008)(55016002)(50986999)(2950100002)(50466002)(9686003)(47776003)(6916009)(76176999)(189998001)(81156014)(83506001)(54356999)(33716001)(8936002)(97736004)(81166006)(25786009)(58126008)(68736007)(54906003)(16526018)(8676002)(478600001)(101416001)(16586007)(5660300001)(33646002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR05MB1933;H:bars;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR05MB1933;23:1FfJ3iF2TGUWPueYUuzMBIOA7YmYvOapu6mt27rss?= =?us-ascii?Q?l5XA21RV4CGhPP8MBGWYyddFsZAzJhCp5c3S4dgyjs9j7V3eo6Lxs7D7fKND?= =?us-ascii?Q?TCUf0+HAJf2vI09cVapC+rM1IjmSpndyZMSTh5VeAQ+k9612B91eul6v9EX0?= =?us-ascii?Q?nw2EvSHL15/iwhios3rz6qKHUclU0ieB4AQjOmaO4nxRqzkMMqU/Qo8jR46l?= =?us-ascii?Q?RYB4mcpb91lLmWDqBF9jI5dze8wCVOrbPZtlOvNfxlZymLfOAgw++Cg7VSNl?= =?us-ascii?Q?rFhplLdbvxWVMjYqrK147DVGVuwccz2XnsCucUUYFeXLx7MRJCw/qZpd/htS?= =?us-ascii?Q?z3P0sg7gSWAsUqYsInQQRdMZOPnjfMVGipM6EMGZ1AZ+snrgPF75p1drgsVJ?= =?us-ascii?Q?Cc3u5jxwbXi023IMa4vVcta+K1VYn533NU39bsexYoiGNAKRN/rRc7nBfG6G?= =?us-ascii?Q?oJ1HDDyuY6Z6DHlyjRCGDNNZFMwuWJxlGgVjxITHUbA7JSrDbWgNH1HAsCq5?= =?us-ascii?Q?8wu68cXzqnjG0LOqBMtUfhccPMqqf/IUDsSUt8sHwYGCOF61dHCeyQIPIMRL?= =?us-ascii?Q?C0q1j6QTrB7WUNfz7ElcBvm37wqXig+BDr/7LLQoWv1VEF45IopT3agiLnie?= =?us-ascii?Q?9ySRsuJO1mckqhnxFzIfuEVc1DxkkWcpM3XiAd94SslfUXRFWfQ6BMrqKSQf?= =?us-ascii?Q?C7qnSPqtRaXsApkDmDxLDaONvK8Rq/lTmGR/TkymaD6nnF/LXXYuxxjwD0S1?= =?us-ascii?Q?1qeNkVOJmBybFzEPwD2TPcrXUfSFmTBjLEAqlmiYVvuS131/VkoNjiBfXbWI?= =?us-ascii?Q?5GAJ2VcAHADrMzqs0KYhbnrBv8GnTiAZqBQXAedYZ3+mjWLdCRBiKS00kLow?= =?us-ascii?Q?18xvzkRzNFO9Mzlz+FGZJKreY8b6AEoZlhLAsaDsPOwKjAxJBezFZWqYTSgQ?= =?us-ascii?Q?1HJotgNe5zixW6mGsAauXOUnTovjoOuXFx4u8xMgWmtQoYXKThTU+CFrKCLC?= =?us-ascii?Q?mZBi2NKALbBBOgsRw83rjHU9o3/wvy2O+/XNZQRg5tzQzt4B6NCIG54itOTk?= =?us-ascii?Q?XG0jVD+tU0/QewgmpINUUeJAq+JV/HSJ87LV/I565X8mFl1eJMhFzJXCuuC4?= =?us-ascii?Q?A2P/99ElsyXKUeIjZv0B4GZAwuJaE021wbyV0dSGPzoDSvLKwIw1p1q4CeU9?= =?us-ascii?Q?0CXblDdZLt5iz0=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB1933;6:LAdk4g3YdzyED86qDFGW54bz4JDHjNG3RHrmDqUTg0RldO1n9pU484b7e/RQoj0IhWl1+zhm7Bka5b01Zg/4MitHXo2gRvj8bCl1jBeV7MrZtmRHDr9eKnW/kdBbmBBFxnNUTLmIjlf2sHK69C8MaIKWHQiRmO0BNYsVd5W48o+HreWt5owlhJgVCoZmqvChfcX7Gl33w2XNEbuJZgdocB3KcNRDAUVLsI4wCCz78p9N7ARB5gBqSbf0ka8VTqHyyZvyNFnbWprDygliRxYOZmpn1Jn3Un9weR8O/HH0z18viN2CEYLSjBOPYbOHmIv0EnZfEnoxBVTk46W+7VWeEw==;5:FqsJq4mPnjpcQYy/h8FezVygjc/MEMwAN/da/O9BkaAX95nJLZDNYsELEp1L842tz15PJBdov9pSfYaDEBW2f1ZKxAsoPw+AdjcECW2jIsQRftZZCC744bz+vu/vrj6R1Z6LXknsoTDn9ByLVM1Twg==;24:VtEH9gYzYWgq59xcF10m7iPQxV8dJcb+ZrwqoM+HuN5UdrbU7+31S8s08/1LGIPl+R+CJo/ay427Dq/83E0fZHtvPkHex7kcfrJE01X3z3A=;7:SxeOieR8DrbUDz7lusmbOScR02kbvlhKOKmRAckoNREL4oepYvSCl2soYKOehVcmRqYax/xFOx1vAPvzRUpP+RLIvnVV/vcKHoZWHMm2gmRGHoSk0cne7h3afPlmbZQHGfIfB/8xuOWvGTDPPPtiQO5DbazFIJJd5ftZpiehwkj+wQs/Qaib6nlaWOXd9l/LJRJC8qlIa1sb5heLx3RPSu27+Y+YwbuJx9VZecphZhI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2017 08:40:02.0368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR05MB1933 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Igor Mitsyanko > Cc: Avinash Patil > Cc: Sergey Matyukevich > Cc: Kalle Valo > Cc: Kamlesh Rath > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 7 +++---- > drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +- > 2 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Sergey Matyukevich Thanks! Sergey