From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760043AbdJQJHz (ORCPT ); Tue, 17 Oct 2017 05:07:55 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:63413 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758488AbdJQJHr (ORCPT ); Tue, 17 Oct 2017 05:07:47 -0400 From: Arnd Bergmann To: Jan Kara , Andrew Morton Cc: Daniel Jordan , Chao Yu , Arnd Bergmann , Jaegeuk Kim , Kinglong Mee , Yunlei He , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] f2fs: use extra parenthesis around assignment/condition Date: Tue, 17 Oct 2017 11:07:12 +0200 Message-Id: <20171017090721.1393677-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Rh8vvDwqnBdLbOGh0e7LR+Hh9zxQH+l4oK+rqNnNLRFXK/ilRy9 nZgQbV1MAVa44sHImd0TTm8y9AqjuBWz2mJgm3vXLMcnIlRYU/J2ey03uAi0ZyJ8LNwHBjP K1+BdxkOxYRbKTDyFDf0/0BnInhJEiPDvU63OkAKKAYJkVgqcVHwv7D+YicHVUKahbkVjT9 XOur2DEDcJH7gUKnQiEdA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TFDHFujkmrA=:4TnT4svEORZPGiqis5Yn+x htUl4nSTBfhMTDALVpWjSZXStOPpo623hByV8gr1iRPW4XwcD/djoR8kWVGl/v8KExW6vvLcz BcsdSiYmYJldyODEs3bfamfBZVA+K/qeftysJ20ORzBxqgvikEa2J95CNbu74o3N1w1/U+GYc vyqy6e7QETE+uB1CHfDtaKnUGV/u12z6FdwC+H9yQTyiT094uZNQQHNht6IWoehKI44xbRpOS myAg0oTWkiJEDZFaXr5niShPhNR5We5A8i3xEKnAil5q0VjjgE9P4k+hrERPO/mNLfD1PLLPc Kvu6YV4RvPa6KQZJLhjCdGY5lMiaOgmgc8Ggfrg4Lg4mjhrGuUpIiUNp4nZCLrAB0eV0OCZCv 9a491hsxZBesqG+laWCXaJg5jb1T7CiVskS8O9gPiYAMf1HRy/UVqCk7IX9+s2Iea11xuWV9f 0TwDnhKrTy7isHv0Stx6qSvx+cFvOhB5RpXFLUZ1+cg8fdcA3AGiXWZDC4Kznaqim6pPjl6Wn J9ImdzvQqdodVCsCvzQcmmYLPDtS6bXM8SQyzKdumr6r3+Z5StwwFjBkDZvIGnmoR7uIKj6ko 0d4Y9ySZGwuGdQja8ZrBNYJZsGWyw63FW+KuK8umZUuGb0HoaJHb+CgjyKI89eeBpnDxP0O8O /2ATRpqxainvhyXV1YpLPIZ7PoGQ+QtYB56QZVxwj44/e+hlcLGLMDTbamyFHYFWQIwBYRqjT nTzQqNuh/jE1BMDUh5OClmP0wuSrkALDm+ntbQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns that writing a while() loop with an assignment as the condition looks suspiciously like a comparison, and suggests a workaround: fs/f2fs/checkpoint.c: In function 'sync_meta_pages': fs/f2fs/checkpoint.c:321:9: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, This seems reasonable, so let's do that. Fixes: 4aba7297f4a5 ("f2fs: simplify page iteration loops") Signed-off-by: Arnd Bergmann --- The warning is from mmotm. Andrew, please fold this fix into the patch that caused the warning, unless there are objections. --- fs/f2fs/checkpoint.c | 4 ++-- fs/f2fs/node.c | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 3ed9dcbf70ae..6124f8710dc3 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -318,8 +318,8 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type, blk_start_plug(&plug); - while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, - PAGECACHE_TAG_DIRTY)) { + while ((nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, + PAGECACHE_TAG_DIRTY))) { int i; for (i = 0; i < nr_pages; i++) { diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index d4ceb9ebfe92..d6e4df0bb622 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1285,8 +1285,8 @@ static struct page *last_fsync_dnode(struct f2fs_sb_info *sbi, nid_t ino) pagevec_init(&pvec, 0); index = 0; - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, - PAGECACHE_TAG_DIRTY)) { + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, + PAGECACHE_TAG_DIRTY))) { int i; for (i = 0; i < nr_pages; i++) { @@ -1439,8 +1439,8 @@ int fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, pagevec_init(&pvec, 0); index = 0; - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, - PAGECACHE_TAG_DIRTY)) { + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, + PAGECACHE_TAG_DIRTY))) { int i; for (i = 0; i < nr_pages; i++) { @@ -1552,8 +1552,8 @@ int sync_node_pages(struct f2fs_sb_info *sbi, struct writeback_control *wbc, next_step: index = 0; - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, - PAGECACHE_TAG_DIRTY)) { + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, + PAGECACHE_TAG_DIRTY))) { int i; for (i = 0; i < nr_pages; i++) { @@ -1650,8 +1650,8 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino) pagevec_init(&pvec, 0); - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, - PAGECACHE_TAG_WRITEBACK)) { + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, + PAGECACHE_TAG_WRITEBACK))) { int i; for (i = 0; i < nr_pages; i++) { -- 2.9.0