From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934911AbdJQJvS (ORCPT ); Tue, 17 Oct 2017 05:51:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:45912 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934855AbdJQJvQ (ORCPT ); Tue, 17 Oct 2017 05:51:16 -0400 Date: Tue, 17 Oct 2017 11:51:14 +0200 From: Jan Kara To: Arnd Bergmann Cc: Jan Kara , Andrew Morton , Daniel Jordan , Chao Yu , Jaegeuk Kim , Kinglong Mee , Yunlei He , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: use extra parenthesis around assignment/condition Message-ID: <20171017095114.GP9762@quack2.suse.cz> References: <20171017090721.1393677-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171017090721.1393677-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17-10-17 11:07:12, Arnd Bergmann wrote: > gcc warns that writing a while() loop with an assignment as the condition > looks suspiciously like a comparison, and suggests a workaround: > > fs/f2fs/checkpoint.c: In function 'sync_meta_pages': > fs/f2fs/checkpoint.c:321:9: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] > while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, > > This seems reasonable, so let's do that. > > Fixes: 4aba7297f4a5 ("f2fs: simplify page iteration loops") > Signed-off-by: Arnd Bergmann > --- > The warning is from mmotm. Andrew, please fold this fix into the > patch that caused the warning, unless there are objections. Yeah, thanks for fixing this. Honza > --- > fs/f2fs/checkpoint.c | 4 ++-- > fs/f2fs/node.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 3ed9dcbf70ae..6124f8710dc3 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -318,8 +318,8 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type, > > blk_start_plug(&plug); > > - while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, > - PAGECACHE_TAG_DIRTY)) { > + while ((nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, > + PAGECACHE_TAG_DIRTY))) { > int i; > > for (i = 0; i < nr_pages; i++) { > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index d4ceb9ebfe92..d6e4df0bb622 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1285,8 +1285,8 @@ static struct page *last_fsync_dnode(struct f2fs_sb_info *sbi, nid_t ino) > pagevec_init(&pvec, 0); > index = 0; > > - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > - PAGECACHE_TAG_DIRTY)) { > + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > + PAGECACHE_TAG_DIRTY))) { > int i; > > for (i = 0; i < nr_pages; i++) { > @@ -1439,8 +1439,8 @@ int fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > pagevec_init(&pvec, 0); > index = 0; > > - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > - PAGECACHE_TAG_DIRTY)) { > + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > + PAGECACHE_TAG_DIRTY))) { > int i; > > for (i = 0; i < nr_pages; i++) { > @@ -1552,8 +1552,8 @@ int sync_node_pages(struct f2fs_sb_info *sbi, struct writeback_control *wbc, > next_step: > index = 0; > > - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > - PAGECACHE_TAG_DIRTY)) { > + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > + PAGECACHE_TAG_DIRTY))) { > int i; > > for (i = 0; i < nr_pages; i++) { > @@ -1650,8 +1650,8 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino) > > pagevec_init(&pvec, 0); > > - while (nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > - PAGECACHE_TAG_WRITEBACK)) { > + while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > + PAGECACHE_TAG_WRITEBACK))) { > int i; > > for (i = 0; i < nr_pages; i++) { > -- > 2.9.0 > -- Jan Kara SUSE Labs, CR