From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756917AbdJQLWT (ORCPT ); Tue, 17 Oct 2017 07:22:19 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44415 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756405AbdJQLWQ (ORCPT ); Tue, 17 Oct 2017 07:22:16 -0400 X-Google-Smtp-Source: AOwi7QCJeAQDpBLVlerMYJqTgMOHU+BNUbQlM0g4YozxorlNTjBq64mgwZGnVCMAWv/nAt+eIedoAQ== Date: Tue, 17 Oct 2017 14:22:14 +0300 From: "Kirill A. Shutemov" To: Michal Hocko Cc: changbin.du@intel.com, akpm@linux-foundation.org, corbet@lwn.net, hughd@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor Message-ID: <20171017112214.n5emzjzstmbktn6m@node.shutemov.name> References: <1508145557-9944-1-git-send-email-changbin.du@intel.com> <1508145557-9944-3-git-send-email-changbin.du@intel.com> <20171017102203.u2v3p2ivuogu4rk6@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171017102203.u2v3p2ivuogu4rk6@dhcp22.suse.cz> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 12:22:03PM +0200, Michal Hocko wrote: > On Mon 16-10-17 17:19:17, changbin.du@intel.com wrote: > > From: Changbin Du > > > > The current name free_{huge,transhuge}_page are paired with > > alloc_{huge,transhuge}_page functions, but the actual page free > > function is still free_page() which will indirectly call > > free_{huge,transhuge}_page. So this patch removes this confusion > > by renaming all the compound page dtors. > > Is this code churn really worth it? Getting naming straight is kinda nit. :) But I don't feel strong either way. -- Kirill A. Shutemov