From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760986AbdJQWIP (ORCPT ); Tue, 17 Oct 2017 18:08:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53538 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756213AbdJQWIO (ORCPT ); Tue, 17 Oct 2017 18:08:14 -0400 Date: Tue, 17 Oct 2017 15:08:12 -0700 From: Andrew Morton To: Andrey Smirnov Cc: linux-watchdog@vger.kernel.org, Chris Healy , linux-kernel , Wim Van Sebroeck , Andy Shevchenko , Guenter Roeck Subject: Re: [PATCH v2] watchdog: core: Make use of devm_register_reboot_notifier() Message-Id: <20171017150812.187a6816af791519294897b6@linux-foundation.org> In-Reply-To: References: <20170411160615.9784-1-andrew.smirnov@gmail.com> <01843f95-c62f-7844-70ee-eed3dc7d3c23@roeck-us.net> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Oct 2017 08:50:12 -0700 Andrey Smirnov wrote: > On Sat, Apr 15, 2017 at 11:11 PM, Guenter Roeck wrote: > > On 04/11/2017 09:06 AM, Andrey Smirnov wrote: > >> > >> Save a bit of cleanup code by leveraging newly added > >> devm_register_reboot_notifier(). > >> > >> Cc: cphealy@gmail.com > >> Cc: linux-kernel@vger.kernel.org > >> Cc: Wim Van Sebroeck > >> Cc: Guenter Roeck > >> Cc: Andy Shevchenko > >> Cc: Andrew Morton > >> Signed-off-by: Andrey Smirnov > > > > > > Acked-by: Guenter Roeck > > > > Andrew, > > This patch can't go in via watchdog tree because it depends on > devm_register_reboot_notifier() which is still present only in > linux-next, any change you can pull this into linux-next as well? That's because I've been sitting on kernel-reboot-add-devm_register_reboot_notifier.patch since March because it has no users. This patch adds a user. Have you identified other sites which can/should use devm_register_reboot_notifier()? I guess quite a lot, so it's a matter of alerting developers to the new interface. I wonder how. A checkpatch rule would do it, but that's new ground for checkpatch.