From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934788AbdJQUwH (ORCPT ); Tue, 17 Oct 2017 16:52:07 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:47521 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154AbdJQUwG (ORCPT ); Tue, 17 Oct 2017 16:52:06 -0400 X-Google-Smtp-Source: ABhQp+QXn0T7WLEVl8g+WaC5c25v+dFmbWdT88x9zy15LMUor6FsxkLz45FJSVuk+jvzY4a2v6j4Ag== Date: Tue, 17 Oct 2017 15:52:04 -0500 From: Rob Herring To: Jerome Brunet Cc: Martin Blumenstingl , Srinivas Kandagatla , Kevin Hilman , Carlo Caione , devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] nvmem: meson: use generic compatible Message-ID: <20171017205204.t4vfvbc2c5nsrnhm@rob-hp-laptop> References: <20171012152450.12454-1-jbrunet@baylibre.com> <1507923553.30658.10.camel@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507923553.30658.10.camel@baylibre.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 09:39:13PM +0200, Jerome Brunet wrote: > On Fri, 2017-10-13 at 21:14 +0200, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Thu, Oct 12, 2017 at 5:24 PM, Jerome Brunet wrote: > > > The meson efuse driver seems to be compatible with more SoCs than > > > initially thought. Let's use the most generic compatible he have in > > > DT instead of the gxbb specific one > > > > > > Signed-off-by: Jerome Brunet > > > --- > > > Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 4 ++-- > > > drivers/nvmem/meson-efuse.c | 2 +- > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > > b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > > index fafd85bd67a6..0260524292fe 100644 > > > --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > > +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > > @@ -1,7 +1,7 @@ > > > = Amlogic eFuse device tree bindings = > > > > > > Required properties: > > > -- compatible: should be "amlogic,meson-gxbb-efuse" > > > +- compatible: should be "amlogic,meson-gx-efuse" Same comment as for the firmware. > > > > have you checked with the devicetree maintainers how they want the > > documentation to look like in this case? > > You mean "Should we put every compatible existing (in DT) in the documentation" > From what I've seen, at least in meson drivers, only the matched ones are > listed. > > That's a good question though. > We tend to put soc specific compatible "in case" we need them later on. Should > we document those ? Absolutely. Rob