From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: Alan Tull <atull@kernel.org>,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: [PATCH v5 14/18] fpga: region: add fpga_region_class_find
Date: Tue, 17 Oct 2017 16:20:27 -0500 [thread overview]
Message-ID: <20171017212031.3770-15-atull@kernel.org> (raw)
In-Reply-To: <20171017212031.3770-1-atull@kernel.org>
Add a function for searching the fpga-region class. This
will be useful when device tree code is no longer in the
same file that declares the fpga-region class. Another
step in separating common FPGA region code from device
tree support.
Signed-off-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
---
v2: split out from another patch
v3: add Moritz' ack
v4: no change to this patch in this version of patchset
v5: no change to this patch in this version of patchset
---
drivers/fpga/fpga-region.c | 23 +++++++++++++++--------
include/linux/fpga/fpga-region.h | 5 ++++-
2 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index 76db81d..5c086957 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -30,6 +30,20 @@
static DEFINE_IDA(fpga_region_ida);
static struct class *fpga_region_class;
+struct fpga_region *fpga_region_class_find(
+ struct device *start, const void *data,
+ int (*match)(struct device *, const void *))
+{
+ struct device *dev;
+
+ dev = class_find_device(fpga_region_class, start, data, match);
+ if (!dev)
+ return NULL;
+
+ return to_fpga_region(dev);
+}
+EXPORT_SYMBOL_GPL(fpga_region_class_find);
+
static const struct of_device_id fpga_region_of_match[] = {
{ .compatible = "fpga-region", },
{},
@@ -51,14 +65,7 @@ static int fpga_region_of_node_match(struct device *dev, const void *data)
*/
static struct fpga_region *of_fpga_region_find(struct device_node *np)
{
- struct device *dev;
-
- dev = class_find_device(fpga_region_class, NULL, np,
- fpga_region_of_node_match);
- if (!dev)
- return NULL;
-
- return to_fpga_region(dev);
+ return fpga_region_class_find(NULL, np, fpga_region_of_node_match);
}
/**
diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h
index 8c8a3249f..7048449 100644
--- a/include/linux/fpga/fpga-region.h
+++ b/include/linux/fpga/fpga-region.h
@@ -27,8 +27,11 @@ struct fpga_region {
#define to_fpga_region(d) container_of(d, struct fpga_region, dev)
-int fpga_region_program_fpga(struct fpga_region *region);
+struct fpga_region *fpga_region_class_find(
+ struct device *start, const void *data,
+ int (*match)(struct device *, const void *));
+int fpga_region_program_fpga(struct fpga_region *region);
int fpga_region_register(struct device *dev, struct fpga_region *region);
int fpga_region_unregister(struct fpga_region *region);
--
2.7.4
next prev parent reply other threads:[~2017-10-17 21:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:20 [PATCH v5 00/18] Enable upper layers using FPGA region w/o device tree Alan Tull
2017-10-17 21:20 ` [PATCH v5 01/18] fpga: bridge: support getting bridge from device Alan Tull
2017-10-17 21:20 ` [PATCH v5 02/18] fpga: mgr: API change to replace fpga load functions with single function Alan Tull
2017-10-17 21:20 ` [PATCH v5 03/18] fpga: mgr: separate getting/locking FPGA manager Alan Tull
2017-10-17 21:20 ` [PATCH v5 04/18] fpga: region: use dev_err instead of pr_err Alan Tull
2017-10-17 21:20 ` [PATCH v5 05/18] fpga: region: remove unneeded of_node_get and put Alan Tull
2017-10-17 21:20 ` [PATCH v5 06/18] fpga: region: get mgr early on Alan Tull
2017-10-17 21:20 ` [PATCH v5 07/18] fpga: region: check for child regions before allocing image info Alan Tull
2017-10-17 21:20 ` [PATCH v5 08/18] fpga: region: fix slow warning with more than one overlay Alan Tull
2017-10-17 21:20 ` [PATCH v5 09/18] fpga: region: use image info as parameter for programming region Alan Tull
2017-10-17 21:20 ` [PATCH v5 10/18] fpga: region: separate out code that parses the overlay Alan Tull
2017-11-15 15:50 ` Moritz Fischer
2017-10-17 21:20 ` [PATCH v5 11/18] fpga: region: add fpga-region.h header Alan Tull
2017-11-15 15:49 ` Moritz Fischer
2017-10-17 21:20 ` [PATCH v5 12/18] fpga: region: rename some functions prior to moving Alan Tull
2017-11-15 15:48 ` Moritz Fischer
2017-10-17 21:20 ` [PATCH v5 13/18] fpga: region: add register/unregister functions Alan Tull
2017-10-17 21:20 ` Alan Tull [this message]
2017-10-17 21:20 ` [PATCH v5 15/18] fpga: region: move device tree support to of-fpga-region.c Alan Tull
2017-11-15 15:47 ` Moritz Fischer
2017-10-17 21:20 ` [PATCH v5 16/18] fpga: of-fpga-region: accept overlays that don't program FPGA Alan Tull
2017-10-17 21:20 ` [PATCH v5 17/18] fpga: clean up fpga Kconfig Alan Tull
2017-11-15 15:47 ` Moritz Fischer
2017-10-17 21:20 ` [PATCH v5 18/18] fpga: add attribute groups Alan Tull
2017-11-15 15:46 ` Moritz Fischer
2017-11-15 16:00 ` Alan Tull
2017-11-15 15:53 ` [PATCH v5 00/18] Enable upper layers using FPGA region w/o device tree Moritz Fischer
2017-11-15 20:31 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017212031.3770-15-atull@kernel.org \
--to=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome