From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbdJRLJh (ORCPT ); Wed, 18 Oct 2017 07:09:37 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59566 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdJRLJg (ORCPT ); Wed, 18 Oct 2017 07:09:36 -0400 Date: Wed, 18 Oct 2017 12:09:29 +0100 (WEST) Message-Id: <20171018.120929.1774171348326334992.davem@davemloft.net> To: joel@jms.id.au Cc: benh@kernel.crashing.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@aj.id.au Subject: Re: [PATCH v3] net: ftgmac100: Request clock and set speed From: David Miller In-Reply-To: <20171013041638.30763-1-joel@jms.id.au> References: <20171013041638.30763-1-joel@jms.id.au> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Oct 2017 04:09:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joel Stanley Date: Fri, 13 Oct 2017 12:16:38 +0800 > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. This patch > configures a 100MHz clock if the system has a direct-attached > PHY, or 25MHz if the system is running NC-SI which is limited to 100MHz. > > There appear to be no other upstream users of the FTGMAC100 driver it is > hard to know the clocking requirements of other platforms. Therefore a > conservative approach was taken with enabling clocks. If the platform is > not ASPEED, both requesting the clock and configuring the speed is > skipped. > > Signed-off-by: Joel Stanley Applied to net-next, thanks.