From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757631AbdJRAJn (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 20:09:43 -0400
Received: from mail-pg0-f46.google.com ([74.125.83.46]:51084 "EHLO
        mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757240AbdJRAJl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 20:09:41 -0400
X-Google-Smtp-Source: AOwi7QDU6BK5dyaptUuqADVHz+Kqf/YEKMYe+f/9laSW38ho4eHyAOdy2JKp76dtJ0HXnoNxD791eA==
Date: Wed, 18 Oct 2017 09:07:21 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        kernel-team@lge.com, Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>,
        "linux-perf-use." <linux-perf-users@vger.kernel.org>,
        Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
        Hari Bathini <hbathini@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf tools: Fix crash on buildid-list with namespace
Message-ID: <20171018000721.GA11621@danjae.aot.lge.com>
References: <20171017120132.GA4204@kernel.org>
 <20171017132900.11043-1-namhyung@kernel.org>
 <20171017140555.GE4204@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171017140555.GE4204@kernel.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 17, 2017 at 11:05:55AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 17, 2017 at 10:29:00PM +0900, Namhyung Kim escreveu:
> > Thomas reported that perf buildid-list gets a segfault due to NULL
> > pointer when he ran it on a data with namespace events.  It was because
> > the buildid_id__mark_dso_hit_ops lacks the namespace event handler and
> > perf_too__fill_default() didn't set it.
> 
> In these cases, next time I suggest you add a Fixes: tag, so that the
> stable@kernel.org guys can automatically figure out which kernels need
> this fix, in this case:
> 
> Fixes: f3b3614a284d ("perf tools: Add PERF_RECORD_NAMESPACES to include namespaces related info")

Ah right, will add next time.

> 
> The script I have for this even adds this CC line:
> 
> Cc: Hari Bathini <hbathini@linux.vnet.ibm.com>
> 
> I'm adding it,

Thanks,
Namhyung