From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933604AbdJRMC6 (ORCPT ); Wed, 18 Oct 2017 08:02:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31675 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933141AbdJRMC5 (ORCPT ); Wed, 18 Oct 2017 08:02:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 138414024B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Wed, 18 Oct 2017 07:02:53 -0500 From: Josh Poimboeuf To: Kamalesh Babulal Cc: linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH v2] objtool: Print top level commands on incorrect usage Message-ID: <20171018120253.qbcykwl435gof3eg@treble> References: <1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 18 Oct 2017 12:02:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 14, 2017 at 08:17:54PM +0530, Kamalesh Babulal wrote: > Print top-level objtool commands, along with the error on incorrect > command line usage. Objtool command line parser exit's with code 129, > for incorrect usage. Convert the cmd_usage() exit code also, to maintain > consistency across objtool. > > After the patch: > $ ./objtool -j > Unknown option: -j > > usage: objtool COMMAND [ARGS] > > Commands: > check Perform stack metadata validation on an object file > orc Generate in-place ORC unwind tables for an object file > > $ echo $? > 129 > > Cc: Ingo Molnar > Signed-off-by: Kamalesh Babulal > --- > v2: > - Changes to commit message only. Acked-by: Josh Poimboeuf -- Josh