From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbdJROsX (ORCPT ); Wed, 18 Oct 2017 10:48:23 -0400 Received: from mga01.intel.com ([192.55.52.88]:7305 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbdJROsV (ORCPT ); Wed, 18 Oct 2017 10:48:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,397,1503385200"; d="scan'208";a="1232223051" Date: Wed, 18 Oct 2017 17:48:11 +0300 From: Jarkko Sakkinen To: Alexander.Steffen@infineon.com Cc: andriy.shevchenko@linux.intel.com, elfring@users.sourceforge.net, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, clabbe.montjoie@gmail.com, jgunthorpe@obsidianresearch.com, jsnitsel@redhat.com, kgold@linux.vnet.ibm.com, mpe@ellerman.id.au, nayna@linux.vnet.ibm.com, paulus@samba.org, PeterHuewe@gmx.de, stefanb@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions Message-ID: <20171018144811.klfmzikibuux77pf@linux.intel.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 11:50:05AM +0000, Alexander.Steffen@infineon.com wrote: > > > Replace the specification of data structures by pointer dereferences > > > as the parameter for the operator "sizeof" to make the corresponding > > > size > > > determination a bit safer according to the Linux coding style > > > convention. > > > > > > This patch does one style in favor of the other. > > I actually prefer that style, so I'd welcome this change :) > > > At the end it's Jarkko's call, though I would NAK this as I think some > > one already told this to you for some other similar patch(es). > > > > > > I even would suggest to stop doing this noisy stuff, which keeps people > > busy for nothing. > > Cleaning up old code is also worth something, even if does not change > one bit in the assembly output in the end... > > Alexander Quite insignificant clean up it is that does more harm that gives any benefit as any new change adds debt to backporting. Anyway, this has been a useful patch set for me in the sense that I have clearer picture now on discarding/accepting commits. One line minor clean up will be from now on automatic NAK unless it causes a compiler warning or some other visible side-effect. /Jarkko