From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750992AbdJRRrl (ORCPT ); Wed, 18 Oct 2017 13:47:41 -0400 Received: from mail-bl2nam02on0088.outbound.protection.outlook.com ([104.47.38.88]:31040 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750782AbdJRRri (ORCPT ); Wed, 18 Oct 2017 13:47:38 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Date: Wed, 18 Oct 2017 10:47:29 -0700 From: Felix Manlunas To: "Gustavo A. R. Silva" Cc: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists Message-ID: <20171018174729.GA14189@felix-thinkpad.cavium.com> References: <20171017185920.GA16976@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171017185920.GA16976@embeddedor.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR1401CA0005.namprd14.prod.outlook.com (10.174.253.143) To CY4PR07MB3175.namprd07.prod.outlook.com (10.172.115.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c237a5d3-bcc5-4ed7-2c1d-08d5165051d3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY4PR07MB3175; X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB3175;3:SVkuDdTyHBtkm87+HbrFHZSBK2VOmR7LbQb0Zo4SHu83zxSKDzqwGvR/kcxPj11lc9BzamuITVaYWDpLbf7Ln1MN3TdlKBfqQevOD4Lo9Zo7RlblEdvCcC8IKUjvoF9cdVcwQLZypc98imMcaTELAeYG0T298WlgBlk++Iz0cPjPQYVZRF/1Zdp9YRqEmU45CnZmbj9Iyi7JfVrAt53C4ClZa/ltNRGj8ZpbofSiPhL/ipPk4kH8X8stF4VBCbjw;25:gPGTkk94jbYwWx7DWR1GHg3tFFPkufyHquc0pBngU8BIcnrAB62544cp8w9Xhh2Qj06lDC9ejbkYFGPEXGWd1lrdtbZjKG0EDVoTAbFgWlL5487bTTbFCqHlrUG1B/S9Qg8w7FCxJkpMHzGptZ3ybYMEEJHC+kNt9C3npdPChSAX0tsoMmdTNGePveLVDBvkFK6kw/ICPuW4lpfbzJzaFu0F037HPDlwGVqNjGGutgoSh4w7VBu5ovkJ+etfK/fEIDuOc77Tx7sUCW/0izrmfsPlNWb6TSVeQlNzUjPeMhpZ5fFYv1jSMie/tBP59wCB3KbUN3HBjtaCqNMAkN8bQw==;31:Yftig2A56hmL7hZaEJlruddlrlnrYfNEKYnS+FfVFSH27TANVXZKWfK3WkR9b5OafYejaDOsNPDllA5bbnRYF++T1yOGoP5guUBJmSPSZZBDVOskl5mqUgAQz51N6biAikNk2f9BvXbwDRiDMsYokmMY1wtTyY882e8EBe2/+lEc7kA45Ez8HahO7HzMbcEMKG9bVIkCyjJ/HwO1Q/fxVhDMPDnGPyicY9tAygYeNBA= X-MS-TrafficTypeDiagnostic: CY4PR07MB3175: X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB3175;20:wHhWol90iToMc87SUIBf7LqD9/p4JkgOQ/FSLdH4FkHmb+yCBCcFLwt1YHDeJymeX9Fjgn/dxkjR89EcHp+ijza5VDRDHy9cgxxAz3VVH0yMakL1oYnCVwiV+EvYFMFV4bK1dKMIqYpH/5wiCoO6QuZ2SF7BOEmt5oLHUtqyXRIvoZHuOXw9VS9xUV1co0KRVZTuqfx8Vzl68R+AkTYf9ixoQi7eqmXqk66Bq1QaWQ4fYRa9y4TH28Mdi2aQ+m6U1Az4/oY48nF2ZfrjJ6PkClhwSujjOkMWUbMW434PqJoxc44hAsSSsNH3yLXy4+hgy+rabGE7F5pz2sV+3HcmYlzcx/3bLmSSgpVJAQBBqMIak1VZS6z+7asoBCnToO14H3SbZ3FYDn2zQ2Us09xvT5z1MSWK1hNehtMLgJOJUivuzIKLsAtddZ1wcDIQqAlg/UaU5IotJ/HYT53RMfi07uICTWOxTlq6G6JYpjBg++/nghNJBTCk1eW1T6/IIl3Q;4:64Q4Bjw6EML5uYLH/fSJ8PJR/1h6UmWe4m6AFLHB1VC20z++cgA2NyX2WMI5H04pppmJqCPCuxE6Kzqc4U+R3PKMsxCWTKL8HtpFF8g4JZ4hjRvyd7VAtSRE8CH5Dm8mwnCSa3snLX0oaRWmhxGS+c9vi0RUBLpxEjeGDnUucJ/HnzBiyMVCF9Sty819liYzm7vQEY3NudXHwr3exWGxvxw/hmcxtkCrrLrj8W4K2Swx+lVK6EjnxuHFMJsA8xNV X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR07MB3175;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR07MB3175; X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(376002)(346002)(24454002)(199003)(189002)(2906002)(68736007)(6916009)(81156014)(50986999)(86362001)(81166006)(72206003)(305945005)(97736004)(229853002)(16586007)(316002)(8676002)(6666003)(6246003)(6496005)(7736002)(16526018)(53936002)(2950100002)(8936002)(54906003)(58126008)(47776003)(83506001)(189998001)(105586002)(106356001)(5660300001)(1076002)(76176999)(101416001)(50466002)(54356999)(6486002)(6116002)(66066001)(76506005)(478600001)(33656002)(3846002)(25786009)(23726003)(4326008)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3175;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR07MB3175;23:DckZ4Ri1V5pB6I99XnGoIJsko2Ikzz9QWIJdgI0JL?= =?us-ascii?Q?l/3S3CXgoCOBQhXG11Hr6B/c8AWrJ31Br6tGk80D02eHjzG1IX3ogdMKmTpe?= =?us-ascii?Q?vw/DS3oK7//CGeoKa7kJbni5kjKpqTiHUhpSoiklrR/tF/npeQeHb9DB/yrZ?= =?us-ascii?Q?IqIG8hczCxFXTc/GH/tQh05Mx1UliiFniZrNaAywjKhYIyC1upGSBIQ3brg1?= =?us-ascii?Q?/ag9LsbM8QQGw6++h757ofoO4gdgPIt0PP/MQvdFBt24hEOx4cI1i1oZ5Z8g?= =?us-ascii?Q?sxnZakkFWuN3DWqjvR1iDIshfvFFgeKWkQgeawyx4xUUbjKEygkcUK+xPh6n?= =?us-ascii?Q?/QG9WAPViudTrrh2HJUT3wR7McmX5BeOZhhXh+sBWZ8JEIOLc8j8vDEz1VGh?= =?us-ascii?Q?b3UUX2VRC/dozHRLEmHz7WS5YjLMkX3V4ByE7xsAXSz0fRwioMmgBNlwUFA9?= =?us-ascii?Q?Hef9gVCcAn85cdUe0H62ABWzjY+o9ME30XiP9zBn1emxL3+935A4B3BxsWTX?= =?us-ascii?Q?1ihNKDzzALmGK7wZjb5hglzr3hdCcGd9hsBuhHz7d9ySO570/cost0nFt+v3?= =?us-ascii?Q?l0EKotqFdXjD/C2Q9t/zn/MxtTBBiT1L2CN96k9GlNjCg3XPHxX/XvSI8xyn?= =?us-ascii?Q?nXQ1IzgvFzuJbUJen4JFt8Hf1cJCddjZ0J0/+2I++hJ+C/mlBi+PJ1rBC8vt?= =?us-ascii?Q?Gkaxa2fmT8VQ38FSYg9roHli5bOQ8QOhwZKC2CGSMHI3cGpSivsMawAPH/3j?= =?us-ascii?Q?+sRBDzuqwgXCTfx7n1KYSd5sUG4GYQY0YU7WeKduDOxGPsRNX6pkSCADJa6M?= =?us-ascii?Q?yQG7EhpObj6TEFM+DxfjeSb4xu8bxkm6kumXPdhSiQc52bdopMVBz6ldilqw?= =?us-ascii?Q?34G8op2+oSjpR/pwKr8E58S/MC2aHgcN3p9eefQUNJ4a/MOVr1nfTSes8A2d?= =?us-ascii?Q?ejs1Ruh6ePefy/AwlT7Naq/e1xvWzJTpHVIdgDLGe/RZr7KnjR09E8+ttGSb?= =?us-ascii?Q?a8yuIMFreuco4L9lk0OSMpuWUYUDpcwggrMx0/6Kl5mtbAeXe4tViKix3ZrQ?= =?us-ascii?Q?tJp+VfwA6sX4oSRWwYmIzo+MJluTnMKzEM+IrFi1bYgTptCw7aLC/I9fu1G9?= =?us-ascii?Q?cuEOGMJY1QdWaJNpXH6MDv9ChlX6NuzR/c7jnqbkCTdNN2LHVrtkoO1NRBGf?= =?us-ascii?Q?PExjKQCXj0gKMtPKmAmBeMO8GbkuOssitaJlX74Gn2rc3UjS0pM+inQPA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB3175;6:CK73LmRUwFiGjCAdf49kMudO3uCEGwTZHrweewfgD4E7V/pSzW0RIjkV5MGPFI0m5shNSIe0OUjqPJOHz5AgGwsHMF86JENT0fXTN7qkcFmZS7HCc2FfZMtMzNPcrEmI3PmnWsQrZWkDhkaB0D8QOZ0jwRvEhDkZS6QHbFsrt7/dldHrwTqF+PHlPgvgbT2afasWguN97LkVbGxtX1pQioRS6JBPrEMOMKV/Y5kaNimIFaY6wdCNbn59l1inX0u/dLwj5/gQziGtOV7lYO+89vUBAsRQwHXWlix9IJt0KB+z2TM5Jn5KExsWPCz1oNg41TDOYIhj2SpK8kCbG3SWQg==;5:lJqS2ME05e8OSRMxPjbzd1NFavoEdC6c9xEqru4sMlU5tMH9ksTU9ZL9OaMviATk/Q6DP/3V8VNhitDTpfQKCKKgloCF2y9TkAXdnPts/KDDlgmjAjSH1sYT6d3+YkMm2VvlVuxEFe64ypLV8CUpVk8BGOu1BPoG+oJ8ePL4FmQ=;24:BD+t81Ts9yMZntGLKhx7CiI0oWy3J+iZ56R1uu/AU9PZ48s5ZZDQHmVFbE24jVcNZemjPZPIOnCk2A2OaT7Ja5h1BrpG71+BZWeGTiNYMvQ=;7:QWkq5YinFx1FaNkNQBLBdNRRnprDa/x6kliSmUZFlmik0rxTbjPVC+ee0p3qEpRBXYQ74PupcWc9ZeGxnmn0r0p3oW6dbnvz/vTsQFgz1l7KvTgup1v+K/JBdGms+Vlfjp0EuHvKgDT9KyTyuoaJnt4SAoJCnUp82vNZG4OLFYlHXsFJAoLR52RaCti/xVZALh+MSgcZc67T/iLM9HhWp2Z9y2eF+LSBt4sy7dJ9eTg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 17:47:36.7531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 01:59:20PM -0500, Gustavo A. R. Silva wrote: > NULL check before freeing functions like kfree is not needed. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > This code was tested by compilation only. > > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > index 2e993ce..e4a112c 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > @@ -435,8 +435,7 @@ static void delete_glists(struct lio *lio) > do { > g = (struct octnic_gather *) > list_delete_head(&lio->glist[i]); > - if (g) > - kfree(g); > + kfree(g); > } while (g); > > if (lio->glists_virt_base && lio->glists_virt_base[i] && > -- > 2.7.4 > Acked-by: Felix Manlunas