From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750979AbdJRRyE (ORCPT ); Wed, 18 Oct 2017 13:54:04 -0400 Received: from mail-sn1nam02on0071.outbound.protection.outlook.com ([104.47.36.71]:45600 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750724AbdJRRyC (ORCPT ); Wed, 18 Oct 2017 13:54:02 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Date: Wed, 18 Oct 2017 10:53:57 -0700 From: Felix Manlunas To: "Gustavo A. R. Silva" Cc: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources Message-ID: <20171018175357.GA14232@felix-thinkpad.cavium.com> References: <20171017185920.GA16976@embeddedor.com> <20171017190145.GA17015@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171017190145.GA17015@embeddedor.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR04CA0061.namprd04.prod.outlook.com (10.173.46.23) To MWHPR07MB3181.namprd07.prod.outlook.com (10.172.96.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31ddafc6-88ea-4f9e-fa9f-08d51651367d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:MWHPR07MB3181; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;3:NukpU/z9VieoGIx6pzZtiVhwdn0DoX4rxhlS5odHvzmxpZ9OtdE4O1f60Z7osWbgXo+5C0rJCu4hpf52O7Z5Q7f0nDzwyzti33KH7+mHh6GpwTMusrVMx982ov/Ap37zUSPVSGHAviJMyPcHDU2A7DZZnGEMOxMOEa35BSk76NO4jsd+sFvJy916sQtvSslWTP2+ZRXvkvls+/hW5Ha4mshmvEpJcPr3xJEmEtqFx9TxIV6ar4TWU/TTEd00aZ0l;25:GbYbfmJK60DdA40jAiTEDNoWMrV216Tibvq1VV07NXjtXeMEQSbUJQ1gKlS7L1JhXAMz4jSI0ibWniePKQ/rX582yF8nddSw0IAK4a0+3Y4wg5m5HEklKbRMle/rVeaK7UyZ5J+nXT+xIyXdjidnF9Sbd9bq9W6oFvUOwNnJv69iiXBbeSxdN1to0IcGfw2KVF3sAC8/2aPPCEuyL+AzJJjoBVb6ui182zzBRzL4xT7ZBvK3xbNInDrHd+xvT2kKV+EDTDaVZ8TYudwXb9oaevm9ErpeBdBJBmqw3QB8hNYdJXQldF1fzgdAvkH8gQhMdXP21iWb3w5E117oEHq+LA==;31:vzXNxiDhQ1mvcFEBm+EE1Ae0sk2Jmh34Ciq7s3Ltf4oRKT9aRoSly0edh3fW8JQYjciX6Q/0Dv8jXmgTCUeCVgVZXOfchUUMR7zlMxh0d3lhtPbwQE7C5MLdB/YekpjWHlrJnIVhvdfs3/GOs/DlBEsz3G2ngBp/4aDeRwAA5kn4+bG/nlGBZk7BNEgfTPiqhBtBFZkDEXJ21hCDFyQMAb7dng4j1Owc8pBJol1tskU= X-MS-TrafficTypeDiagnostic: MWHPR07MB3181: X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;20:eye/L6xbtWzI298NV8BAMcimPvX6YpY8OtSvCPJ6t8jmklktoo2nY5PauFax1t/5Mt9c45jqD32fEaeuZeo9LbCgfga5++0lYbSl76Jajjsu3udjxF8uL/PF6dAPFPHeVIb79LWXP1lTEWA2jHTTTyewA4VoM7c9YaN/uHRLneu0mM+rSDX264dfrM5wjW2byP9bYl8ndCuJgOx+PaMhtsGSVqDT75kCTu1c6CbMuvf+J72BPpOjK+bo7P7ZcxB/HsGzzb87KJO09gCbbyGdWY7nJOqD83TYgg8qDAzbM73pxtQBk1zkVNJ8xH7+0fasL/7EiO6lybpCwWspW8Y5qkHNHasQC4mAbPZXRJy/RIDL0wY2NsfxO7LwZBAXOIWm1YwNo5YFWSTLWl8rpKwGa7BKUo4tmj5/naR5z5eUsXKroH48IODqHOd+yalLvUuSs0r1ZSZaF+GFjA4p6OkMdmXPfc2SGgp7UJIbMzpeU0WIeR37wLZeWv6LSaCu3mq8;4:7vrnM/J2vKMRR5ByrQtGrr4FE65VGKHZ88hmQBe6zd2LX/yDDTYRcdE90H+B3zy/AOlRH2GZNppFxZ8+x1MTxf/Edh7hwbrjAxZhqNKmAdvCZhYrXBKJf5bKVrHjy++32jkCd2kSpaCtSIBmxGJ5Ave/BI4OPc1CbgeLjPjnzC6G3jOAm6pGtz4kczq7ZzfUfIZadl4Cs778fm/cgDEQkJWUiZUDLLU6VJWJPTLUv1dgBOJcp6LeekpZEeY10z/j X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3181;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3181; X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(376002)(346002)(199003)(24454002)(189002)(6486002)(6246003)(6116002)(8936002)(53936002)(83506001)(6496005)(101416001)(54906003)(3846002)(4326008)(81166006)(23726003)(1076002)(33656002)(81156014)(5660300001)(66066001)(68736007)(16586007)(8676002)(316002)(6666003)(189998001)(47776003)(97736004)(58126008)(106356001)(76506005)(105586002)(6916009)(2950100002)(229853002)(50466002)(16526018)(76176999)(478600001)(54356999)(25786009)(305945005)(7736002)(2906002)(86362001)(50986999)(72206003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3181;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR07MB3181;23:mA8xmP8alFQAwOHKiP0teJI+DD1a089IQlZqNidMa?= =?us-ascii?Q?pC9VWN7eb4ZadMyUV4Tpftd1zwVwV7VZHwSqwnnVcwv21geSSAMlEsn6z/ej?= =?us-ascii?Q?nmrQOjN2GOej7dtJf+a7CfX22pymMUHD+NTDYgm5JgsuA1h+aFUjyA7PKI3x?= =?us-ascii?Q?6J33nzs+sYKtibF0yf8kuucVk5ugzf4yawDuCOn4AVa1zTsizjWO8BIS8aNd?= =?us-ascii?Q?c9gU0ki/fTZKVzjCivmOK6THtbhHBxvAJMBCr1f/Kx4/8aWCY2WhejYK/N5h?= =?us-ascii?Q?0bwNQca5yDk1NSvcifQItjstCbk+YHZxymmZ7kHHsnQ5Es1ncNZx9tl+TXNI?= =?us-ascii?Q?VE0DzKaPZKO7m0BneQc9h1cf9kj/LAyA7OfviSZz5mDQRp2DYbJDbu4mZ3BN?= =?us-ascii?Q?Dwvks3PbkpSuhC4HWIo7qJlI7lbQHmIrc14ZhVOmXcKs40ma4FztHiFw1x5u?= =?us-ascii?Q?f4L2xVql9dlwKSraeBRB3iTbJk/yjAf8t8cAFP6D7qmrBGF03qmA10oVfP1Z?= =?us-ascii?Q?uSM+quUSZhF6xryPcTLor10ul/qQ9banSdcUnWbml+Asf5XVl/OFM6IqzKNZ?= =?us-ascii?Q?wzy+25Le6U0BfCV/hD1/lb6dSAu+Mj66wIokKzWUFVDeCD/reBqR0WDIrHF4?= =?us-ascii?Q?Pikok8Vs1XYuHZAr1SHK7vbBik3NJEiqULoMQujKDI6k8DmJ8op67yTao10P?= =?us-ascii?Q?1WsAODglCrUmIYSNKOklUF3P3D3vcRWnnadTakZoEuvxXQ/dskcSQubhuPSJ?= =?us-ascii?Q?EEtegjc1Fu72OxmOMd+QHTt2l18bzz7zwi7cB8wcb0NHye3zZ3tRjNyTJD/i?= =?us-ascii?Q?bvj30YDlXyrbCrwOCBJ5WQeH4ZwIQU9CS7dmT5sov5Wa5v6XjcE1ZlklOv9F?= =?us-ascii?Q?s1dtCsRv+E6NVyCzzlO75+EU/2TuZ3CLhlmRFNpGgGu54QQW6y/eiFLmodNC?= =?us-ascii?Q?8TImEwa4oR1qxFohbHhunD47zAdCgt9ndvk8tMNPZe2ujI2zqoX2dkjWeCfm?= =?us-ascii?Q?UO4chH0xx2CD4dFfif7HSy9rtMk8FXm4wQ9EmL6fAi+vKekpDvZ0go0GoMYv?= =?us-ascii?Q?DcgemZcTscN3OYZdLHwEq7UPp8cIvYc1OEzNof2ErwxQIuM1uI7xhqVYCtau?= =?us-ascii?Q?O17OKgNJnLENBmxrsXDdrfeU0nCZ6HrlPnxgutOWCIbmrXocyI7SUJLXDlYU?= =?us-ascii?Q?48GmwwnM+bYTeulhIMiE9uRjkZ0uScpLRIAMGWDhisWYF/2tEoNkChnag=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;6:t6P7f7vhlnMT1rkNu/1Exwj8J6tE4s/s29Wz92o+5HAQOBqRP/bontjYmoa0+UvoXU6XKjM61UYmmPXcALM5b/LTD8AAXLg35FoRNnESXxgYmHXtEB/cwWJoFjX6XODjdUOv2WxDrr49y6uwCIDSRnrgmaHvzY3SR86fVEPht28JYQr2nwpDl8z2PX5EjUFAk1rX3MfUL75YLUHLp7MztWW/42ax9SqbgXuvI7Qfva+oI3AGmEnF6I4MVP1WdTBpnoRODYC0rMMntxggSchuP0ybcIIbZxSN+C0o99Ee/zrd5M3WZzEovUQc8Y+eEneoY8cFPmV+w12SBRZ5HbsUhA==;5:yIT+stjEE+vl910kYRejqFWnS5h1/W5yVb70bKzasFfkUzR0JDF4f9Fl2W1Sd0Aa6lnW6ZTCfAetLt6ZhoOC/KC+Yrw8Jw6w0w7CeYitVa+5Cno0e7j740K5MRvv6TUm0xoIy30jqCuB85o1oc0MuQ==;24:BWhjWGqXgQaXOGcpIh2ymqktkBy2khWfPfQSnI/wonQPBNrMm0b8yD/KI8VHjQvsFQFsTHY4VBNfCQSXp7Htcq2OC83uFWyBRVL5eQYiFsI=;7:0Bj3Y7pjqOxiUPJWSXxf72r6FauVjNu5oqqjE7N9XmZQvr6o06oRa+UC6hwBVHWra7Qr+frLpKcGELpR2wciWwzNEYRFGXW+KGHafJ/0y++Mhxy4kYTZo/j4hHGdoPjcAnNxO6rfmAEUuZpJc0gwtqUMpG1jsReg+7fOpIaqv05wFVe//HoZoCfAmo3TmPwfYhMeqeFZZ0BBnNtkimrwSdrNsaN9G1OMZdziiYP9gDw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 17:54:00.4556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3181 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 02:01:45PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > This code was tested by compilation only (GCC 7.2.0 was used). > Please, verify if the actual intention of the code is to fall through. > > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > index e4a112c..4c3b568 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > @@ -747,7 +747,7 @@ static void octeon_destroy_resources(struct octeon_device *oct) > > if (lio_wait_for_oq_pkts(oct)) > dev_err(&oct->pci_dev->dev, "OQ had pending packets\n"); > - > + /* fall through */ > case OCT_DEV_INTR_SET_DONE: > /* Disable interrupts */ > oct->fn_list.disable_interrupt(oct, OCTEON_ALL_INTR); > -- > 2.7.4 > Acked-by: Felix Manlunas