From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937904AbdJRKYA (ORCPT ); Wed, 18 Oct 2017 06:24:00 -0400 Received: from mx.socionext.com ([202.248.49.38]:26085 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936751AbdJRKX6 (ORCPT ); Wed, 18 Oct 2017 06:23:58 -0400 Date: Wed, 18 Oct 2017 19:23:55 +0900 From: Kunihiko Hayashi To: Masahiro Yamada Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Rob Herring , Mark Rutland , linux-arm-kernel , Linux Kernel Mailing List , devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar In-Reply-To: References: <1507854928-4357-2-git-send-email-hayashi.kunihiko@socionext.com> Message-Id: <20171018192355.243B.4A936039@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.70 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Oct 2017 01:41:12 +0900 wrote: > 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > > DT bindings for the AVE ethernet controller found on Socionext's > > UniPhier platforms. > > > > Signed-off-by: Kunihiko Hayashi > > Signed-off-by: Jassi Brar > > --- > > .../bindings/net/socionext,uniphier-ave4.txt | 53 ++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > > > > diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > > new file mode 100644 > > index 0000000..25f4d92 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > > @@ -0,0 +1,53 @@ > > +* Socionext AVE ethernet controller > > + > > +This describes the devicetree bindings for AVE ethernet controller > > +implemented on Socionext UniPhier SoCs. > > + > > +Required properties: > > + - compatible: Should be > > + - "socionext,uniphier-pro4-ave4" : for Pro4 SoC > > + - "socionext,uniphier-pxs2-ave4" : for PXs2 SoC > > + - "socionext,uniphier-ld20-ave4" : for LD20 SoC > > + - "socionext,uniphier-ld11-ave4" : for LD11 SoC > > Nit. LD11, LD20, in this order please. I'll fix it. And also the SoC-dependent structures of the driver. > > + - reg: Address where registers are mapped and size of region. > > + - interrupts: Should contain the MAC interrupt. > > + - phy-mode: See ethernet.txt in the same directory. Allow to choose > > + "rgmii", "rmii", or "mii" according to the PHY. > > + - pinctrl-names: List of assigned state names, see pinctrl > > + binding documentation. > > + - pinctrl-0: List of phandles to configure the GPIO pin, > > > configure the GPIO pin? > > git-grep found this phrase. > > > $ git grep "List of phandles to configure the GPIO" > Documentation/devicetree/bindings/net/microchip,enc28j60.txt:- > pinctrl-0: List of phandles to configure the GPIO pin used as > interrupt line, > > > > > > > + see pinctrl binding documentation. Choose this appropriately > > + according to phy-mode. > > + - <&pinctrl_ether_rgmii> if phy-mode is "rgmii". > > + - <&pinctrl_ether_rmii> if phy-mode is "rmii". > > + - <&pinctrl_ether_mii> if phy-mode is "mii". > > pinctrl_ether_rgmii is just a label > you just happened to write in your DT file. > > This information is totally unrelated to hardware specification. > It is not stable, either. Surely this driver is independent from the pinctrl. I'll remove the descriptions about the pinctrl. > > + - phy-handle: Should point to the external phy device. > > + See ethernet.txt file in the same directory. > > + - mdio subnode: Should be device tree subnode with the following required > > + properties: > > + - #address-cells: Must be <1>. > > + - #size-cells: Must be <0>. > > + - reg: phy ID number, usually a small integer. > > > Are you talking about "Required subnode" in the "Required properties"? It might be confused description. The subnode is separated from the properties. > > +Optional properties: > > + - local-mac-address: See ethernet.txt in the same directory. In addition, I'll add "clocks" and "resets" according to another mail. > > + > > +Example: > > + > > + ether: ethernet@65000000 { > > + compatible = "socionext,uniphier-ld20-ave4"; > > + reg = <0x65000000 0x8500>; > > + interrupts = <0 66 4>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ether_rgmii>; > > + phy-mode = "rgmii"; > > + phy-handle = <ðphy>; > > + local-mac-address = [00 00 00 00 00 00]; > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + ethphy: ethphy@1 { > > + reg = <1>; > > + }; > > + }; > > + }; > > -- > > 2.7.4 > > > > > > -- > Best Regards > Masahiro Yamada --- Best Regards, Kunihiko Hayashi