From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdJSM1N (ORCPT ); Thu, 19 Oct 2017 08:27:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbdJSM1M (ORCPT ); Thu, 19 Oct 2017 08:27:12 -0400 Date: Thu, 19 Oct 2017 13:27:04 +0100 (WEST) Message-Id: <20171019.132704.299365871401082792.davem@davemloft.net> To: kumba@gentoo.org Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, netdev@vger.kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ethernet/sgi: Code cleanup From: David Miller In-Reply-To: <53f0ad54-514a-b572-5801-7bd237055f86@gentoo.org> References: <53f0ad54-514a-b572-5801-7bd237055f86@gentoo.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Oct 2017 05:27:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joshua Kinard Date: Tue, 17 Oct 2017 13:54:30 -0400 > From: Joshua Kinard > > The below patch attempts to clean up the code for the in-tree driver > for IOC3 ethernet and serial console support, primarily used by SGI > MIPS platforms. Notable changes include: > > - Lots of whitespace cleanup > - Using shorthand integer types (u16, u32, etc) where appropriate These seem to be arbitrary, "unsigned int" is a fine value for a hash computation. You're also making many different kinds of changes in one patch which makes it very difficult to review. This driver is also for such ancient hardware, that the risk of potentially breaking the driver far outweighs the value of "cleaning up" the code.