From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751502AbdJSFdc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 01:33:32 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:47606 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750947AbdJSFdb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 01:33:31 -0400
X-Google-Smtp-Source: ABhQp+TJ5mE2adHDKTWeGc6DuSKiEBtnorxGPt59oEnkyOBj0qmrsxGauuvKRO+WUljKTdvOmhkcIg==
Date: Thu, 19 Oct 2017 07:33:27 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>,
        Hannes Frederic Sowa <hannes@stressinduktion.org>,
        Juergen Gross <jgross@suse.com>, Jason Baron <jbaron@akamai.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] static_key: Improve uninizialized key warning
Message-ID: <20171019053327.526kfuuqopqlsg4o@gmail.com>
References: <20171018103913.21857-1-bp@alien8.de>
 <20171018131934.fveczr7gb2iayvaa@gmail.com>
 <20171018092710.4180b41c@gandalf.local.home>
 <20171018152428.ffjgak4o25f7ept6@pd.tnic>
 <20171018120659.1cf162dc@gandalf.local.home>
 <20171018120816.75777573@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171018120816.75777573@gandalf.local.home>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 18 Oct 2017 12:06:59 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > > Signed-off-by: Borislav Petkov <bp@suse.de>
> > > Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
> > > Cc: Ingo Molnar <mingo@kernel.org>
> > > Cc: Juergen Gross <jgross@suse.com>
> > > Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>  
> > 
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > 
> 
> 
> Ingo, you may want to fix the typo in the subject "uninitialized".

Yeah, I also changed it to %pS to help debug arrays, or cases where somehow a 
non-data symbol ends up being passed to it. Plus I changed the message from:

  static_key_disable_cpuslocked, key virt_spin_lock_key used before call to jump_label_init.

to:

  static_key_disable_cpuslocked() static key 'virt_spin_lock_key' used before call to jump_label_init()

to make it all obviously readable. I mean, what if the symbol is named 'key' and 
we'd get confusing printouts like:

  static_key_disable_cpuslocked, key key used before call to jump_label_init.

Plus functions should be referred to with () to disambiguate them from other 
symbol names. Also, proper use of punctuation symbols.

Thanks,

	Ingo