From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbdJSLIa (ORCPT ); Thu, 19 Oct 2017 07:08:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:57840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbdJSLI3 (ORCPT ); Thu, 19 Oct 2017 07:08:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A982218A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jeyu@kernel.org Date: Thu, 19 Oct 2017 13:08:24 +0200 From: Jessica Yu To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Rusty Russell , LKML Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage() Message-ID: <20171019110824.wqkep7bpcx3dcw5w@redbean> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux redbean 4.14.0-rc4-next-20171013+ x86_64 User-Agent: NeoMutt/20171013 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ SF Markus Elfring [06/10/17 17:12 +0200]: >From: Markus Elfring >Date: Fri, 6 Oct 2017 16:27:26 +0200 > >Omit an extra message for a memory allocation failure in this function. > >This issue was detected by using the Coccinelle software. > >Signed-off-by: Markus Elfring Applied to modules-next, thanks. Jessica >--- > kernel/module.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/kernel/module.c b/kernel/module.c >index de66ec825992..07ef44767245 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -837,10 +837,8 @@ static int add_module_usage(struct module *a, struct module *b) > > pr_debug("Allocating new usage for %s.\n", a->name); > use = kmalloc(sizeof(*use), GFP_ATOMIC); >- if (!use) { >- pr_warn("%s: out of memory loading\n", a->name); >+ if (!use) > return -ENOMEM; >- } > > use->source = a; > use->target = b; >-- >2.14.2 >