From: Petr Mladek <pmladek@suse.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: simplify no_printk()
Date: Thu, 19 Oct 2017 15:38:49 +0200 [thread overview]
Message-ID: <20171019133849.GA2795@pathway.suse.cz> (raw)
In-Reply-To: <CAK7LNASLCtO1P2x0A0KgczqnsKYdYE4n9q0ACa4XuWnXZ8CxcA@mail.gmail.com>
On Thu 2017-10-19 19:48:15, Masahiro Yamada wrote:
> Hi Petr,
>
> 2017-10-02 23:56 GMT+09:00 Petr Mladek <pmladek@suse.com>:
> > On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
> >> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
> >> a value") surrounded the macro implementation with ({ ... }).
> >>
> >> Now, the inner do { ... } while (0); is redundant.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> > Looks fine to me. The return value is slightly more visible now ;-)
> >
> > Reviewed-by: Petr Mladek <pmladek@suse.com>
> >
> > JFYI, I have pushed it into for-4.15 branch.
> >
> > Best Regards,
> > Petr
>
>
> A minor problem.
>
> I think "Reviewed-by: " is missing before Sergey.
Great catch! Thanks for double checking!
> I am not sure if this is too late, or not...
Just pushed a fix.
Best Regards,
Petr
prev parent reply other threads:[~2017-10-19 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 15:01 Masahiro Yamada
2017-09-17 18:31 ` Joe Perches
2017-09-26 6:43 ` Sergey Senozhatsky
2017-10-02 14:56 ` Petr Mladek
2017-10-19 10:48 ` Masahiro Yamada
2017-10-19 13:38 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019133849.GA2795@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®