From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbdJSQvX (ORCPT ); Thu, 19 Oct 2017 12:51:23 -0400 Received: from mail-ve1eur01on0123.outbound.protection.outlook.com ([104.47.1.123]:45123 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753583AbdJSQvV (ORCPT ); Thu, 19 Oct 2017 12:51:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=avagin@virtuozzo.com; Date: Thu, 19 Oct 2017 09:51:04 -0700 From: Andrei Vagin To: Josh Poimboeuf Cc: Ingo Molnar , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com, tglx@linutronix.de Subject: Re: [2/2] x86/unwind: Make CONFIG_UNWINDER_ORC=y the default in kconfig for 64-bit Message-ID: <20171019165103.GA15123@outlook.office365.com> References: <9b1237bbe7244ed9cdf8db2dcb1253e37e1c341e.1507924831.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <9b1237bbe7244ed9cdf8db2dcb1253e37e1c341e.1507924831.git.jpoimboe@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [4.16.175.162] X-ClientProxiedBy: MWHPR03CA0012.namprd03.prod.outlook.com (2603:10b6:300:117::22) To HE1PR08MB0746.eurprd08.prod.outlook.com (2a01:111:e400:59b1::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a57457c5-5af2-4c03-174c-08d517119e72 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254169)(4534017)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199)(201703131423092);SRVR:HE1PR08MB0746; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;3:7Betet8HUup/D0mwJupCBzagJG+xhvld9M5j/lXU9OkWfGQoY2H2ZNsXLXbbvfMaFkfk2CpRY1CM7jIzpxCkrPqS6ITHc6Mfuz8zhMSBoeIaKwZ5U0BqdtWq8sbCWB/TuZl/QCgL0zv/66aDXU1J5VxETtSKiSFWcaf00wIRJAE7MlKQh5BoCsunOoWwm5xjnZ19b9wZuY9cH8xMpIGJPbXSJ01mSAOOeaCoq46rZMFSN08cWgTA/HtSiZ5Xv/bh;25:1H7wvdKf7oySwF86L8XB1CPgfUESbZRP1FBzf+NJTQJ/P4oxDko6rEwAcKfAIdyRLGYwWPurvEDBxGEuP8McCCWfn4j5sPyb2SduePephxl1XUkMPCH5XIVfrJKomF/0btzQvE1rQHQapSKuxXEJMvNJXnRyb8GDZVWArtySZuXsBNGnuVrI8UuqYMVsmQv4p66erJS2x9WnCnZtghp7U9VHx08LCo4WeLC8BMj5dbPA7vs8WQeKv8c/hG/iJCBTfQA4eRlGMGxCkarNyyw7QVKHauWx7OKhHOP9po71GevakJ+e6c/jSoVby/tn/Hj7GZj6jQ7u1g80jOuegG4/Dw==;31:8PPw58sglHXF7yxiS/A9iBCCKgKrHF0LM7DhS+2117AaUBpnenVUnh12i+ZSIYCmSEEg7ekwSsFVBgvthDp/6hWcUcEka8CVVji9UlP9cf3XMKcxgcA0HKAPnjTYlQiXYhJ8jYX/R1OvS1EELDiXf/Vx1JhpDDYqDPl6XjLmwv1oRcXA0XvHcaYhhPt58mCKMKJneOg1lw8Dz+5XfXbIuiPMrcWNeUwgTtyjCWDA8lo= X-MS-TrafficTypeDiagnostic: HE1PR08MB0746: X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;20:RJWuFasVx6vqtReX4/6eyndscpgpzOInkSqk7NBEvNCXuBNHZ+CVEaAZNGxQ5CQHrca2JissfR1tA2S9TkIWFzbSzXj4VoS9X92BrIPJx/CYTfd3Ga3Fpgv1st1UTQxo73xSivfA/hMPbSPykTx1wreV4wn9FMexRd/FYW2p0gusI2JyV+ufcxi28xabfLqq4jrb/Cbi87gwcXcWEg0EGGVWzSg81yrn3tCc+R4wN6UrvFGlk/fAQuO3a7MLQJLsDfCFze3pPTiRDsFbndQArL1RJ+82aJIQ2MX90xHA26BZe8bs/3MzLxOrVwlvpdjfMRc3yHAbUu++bCX94fVyURlkN7MYWTBVKty/HPxdWcE5SKSEj9LYr3ENIDUzpdWyIX5oJeEcIk2uKFA7rujXNrbvbcTGRWwEahChZkdKnY8=;4:dDlb+INtCyGigZCPhP9QVT4G9lFbweqGZfFCfn/VMjJqc8QkaOwgjd4ANKTvGS6+Xk9DXVKcp5ZuRzGEN+gks0sNUl6XT4L95FOqCMbmxqcEOM85RxEuakQpg16WZS0gJphz1hxhUs9GvOXfpZli7Z75uYrsym/Zcu1CZO9mzxatJcAjfau/t98GKSqYUPUGdi0PCdqd3tvu2XveR44U08EZ6gXef72voQ4uYFMAi2w8FprvGvbw6XNF8ahh1CL0 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR08MB0746;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR08MB0746; X-Forefront-PRVS: 0465429B7F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(199003)(24454002)(189002)(5660300001)(106356001)(2950100002)(6916009)(16526018)(105586002)(3846002)(8936002)(37156001)(50986999)(81156014)(81166006)(2906002)(97736004)(69596002)(16586007)(83506002)(6116002)(23686003)(68736007)(1076002)(58126008)(316002)(7736002)(4326008)(53936002)(6666003)(9686003)(305945005)(50466002)(55016002)(66066001)(33656002)(6306002)(101416001)(966005)(478600001)(575784001)(47776003)(86362001)(6246003)(189998001)(8676002)(25786009)(6506006)(53416004)(54356999)(76176999)(229853002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR08MB0746;H:outlook.office365.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;HE1PR08MB0746;23:ZUD0U/nrE9AkphTCk4lqxoEZC/miCvUumuYQzlCm+vf?= =?koi8-r?Q?hKLuyjc5xqi4FbaXMpeEmOx+XiwTOz4Nus+wx1wr0rRzENCKoCspnhClqEKAvb?= =?koi8-r?Q?S9dApKg5g/5o8eORmoPPKfEPep9/ldL+XiDYIgO/iiJ914a4IW+9Tjb4t7qs92?= =?koi8-r?Q?BHJJcRdSmlZbMorZEY+Zw5YNMXdJADphwjHjUs4h/O+r4SvfdYjBUPaeWBl2UN?= =?koi8-r?Q?hMvMRVeWlyoKe/MMNW/jGkm66kVcn4JbM6yRUf5fw/4BgtewI5Ww01udTzPia3?= =?koi8-r?Q?Q+X1hdWCpIpD1qF/O36MVO1ZgYw+K5ogzaJSvB4bpfkXJYypaEU46UATnZ8ATG?= =?koi8-r?Q?EVbFd30RPku4446bwxMo+niD0ZYPydryZxsiUN1MO1EYJOOwzksnOiHKw3HRf5?= =?koi8-r?Q?hfIjnNU68iAKk1YU536ViKK0uF8JW4NWUFzmE4gLUu2iYuEp1PhCyiT3ZpI3G/?= =?koi8-r?Q?jLm/N3ZDOICVYaEVt32ldkdZDGaRuAwayxZtqNIxw+qVxW6nQG6yum+vapadh2?= =?koi8-r?Q?iXd5AVwom4oS6TfEFM7scER1zXyIMQTuCxH8pfPeEquzhhCPWgAU8vlrq/iOW6?= =?koi8-r?Q?rwClNUEt4QpRKBdddbEJRH22HXHkPMjw3GaPbPXsoAjpZink5ulwPpNCED1k9C?= =?koi8-r?Q?MlvR5oTzZG4xF8UrzjvikVf+A1B+Mf2pDg/Lx/SOooTM1omgkwI1eHrMIFjnlu?= =?koi8-r?Q?26CV33szKRYN4CqLOa2lBVaxOhLveAqzeiY5Fe56NuwpGJ9wk7vOgVLGMleXT3?= =?koi8-r?Q?B6OPlJslLXxF+w0XONz1dw5FF3OPWR99DoqJn/WwieBw/GjH+ZKX3NxN4YwGEE?= =?koi8-r?Q?TsDhLgGcSKKCj93D6eFSz7M3p+WsLfhITqfY6ZSyF5bEmXhcPy7Mpd6vJKKq1e?= =?koi8-r?Q?io6AbGI4aFGdkmOq8+5x+FxIDG02y2Holm9hx9ybitOdYdpk37Jm2IRT/5UiP/?= =?koi8-r?Q?nf0hudM2XX6QWEVgXc9Yn9jjmqe2CXZLZe/sq2p1pnUM9gfggELDWlSI7DQkuR?= =?koi8-r?Q?vCvnBUpgVymEes2EdK/QNhoG+YyCCSlVzpBw6CLiMERCmpjYkniRYxf9poQ+qI?= =?koi8-r?Q?xgqicqdzN1W4/hKstEH5q2WvYHwL+sNAjCWbRXBnaspxSL+AsS82+PxVELvMC9?= =?koi8-r?Q?w5XhP9Xtk8pUJSTYzr2v4aNzvnneTP/EvbTaOB7eTr1yur6ACmrGITJhcSLukv?= =?koi8-r?Q?ZZgSXvjdpG38RQpn4KcQYrqKZBQRsDQrjcK65GhwnqI2O7hxbaZjQ53o1t8VUl?= =?koi8-r?Q?8Y9g1Oq2OqP7RYYKxBg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;6:CwoVcipZaHCGCpXPT6lgq+MsQuFj87NlXmzFHmws51ZNAAgPVYHdSn+ZE9J2/r/BUincK84TPTIWr+9rQ+X7r+JNaHB8R63ck2sgNIoL8o5MOFB0b7t+f5/6GkLWcv5onbnWlo7wokUXMEz+2gutpyXU0noxWY9y66VtT0IC9GGmByWKfbEipQnRQ8BNvPUxUI1R0ygzgv8WDCeDncIaiQJLEHowpWPTeyHlCUz1ZvC774Vx8R7qfX/+g8U3VEvVyYmwknatElQvxYLV0CUEYWXZx7VD8N8KjakFaIvCFJbY09lhPW/ysE8OOtePd/6VHA8QoseA+ok+idJyUAFRsw==;5:qUj0wyZgdI0qYyThwim5JAyKzlB6rNOAHbcAvAVNPSIz1VqrCTDeu9Ejk42RschAYT6IWbwi1C7vNNLwXNCHm1jxjyL3wfbAroHDF+13JkFn8z+5U5lHsrQu8q1Dk/v4/UrACS1v9JzYoob/UIojQA==;24:k4fa5J9rzp2U/csNZ4+1LCPLkk+DV2JJ1StrrzS3PnfN/R1IQZlMkOU13yhrt9pMAdbPxj8Bn+cVQnPAUYS1EGY9NX+ni/w3bB9GCRabmMc=;7:dyLrn7FFLes6hWLMlDT9PKkTkRYDtp4igNiwMP3C39ZN+XYSw6g/NSvYEoay7eSNUnfHkiEi2XiZhyGSkV7tWbxsHloGwqKa9R9DQFQHL1JA4zP4mexmd3TnOXenERFZU+pZJnsj25L2aNNCT3e7iRg9tzfNlSSOv3UCrhAvVxZFRWm0gjCwfLR3B0RlvUppuoaIiT2/O2pBkvCNNPurOOAl9QiKNeo4+FFzoBFhVT0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;20:Z18R3pNdPpoaUznImkcTR7++jjYzRWTnyTBOwVRCJPqKCvGnYszGriBQwizdBkus04/rMbMvdkY7IVPADLxhFGc/ml2M5yXAjEzOIORlxJCIIONay8NLYpakWDNVT3DZr3nmjjYXqlmNRFY1IO0g0Zj/GDBorxtSVV4cVuNmGds= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 16:51:16.6390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0746 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, We run CRIU tests for tip/auto-latest regularly, and a few days ago our test job started to detect this warning in a kernel log: [ 44.235786] WARNING: can't dereference iret registers at ffff8801c5f17fe0 for ip ffffffff95f0d94b What does it mean? How critical is it? Our test job fails if it detects any warning in a kernel log. Maybe we need to investigate reasons of this warning and try to eliminate it? Here are logs: https://travis-ci.org/avagin/linux/jobs/289676634 Thanks, Andrei On Fri, Oct 13, 2017 at 03:02:01PM -0500, Josh Poimboeuf wrote: > The ORC unwinder has been stable in testing so far. Give it much wider > testing by making it the default in kconfig for x86_64. It's not yet > supported for 32-bit, so leave frame pointers as the default there. > > Suggested-by: Ingo Molnar > Signed-off-by: Josh Poimboeuf > --- > arch/x86/Kconfig.debug | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug > index f274dbb87c26..a4ff214fb760 100644 > --- a/arch/x86/Kconfig.debug > +++ b/arch/x86/Kconfig.debug > @@ -358,27 +358,13 @@ config PUNIT_ATOM_DEBUG > > choice > prompt "Choose kernel unwinder" > - default UNWINDER_FRAME_POINTER > + default UNWINDER_ORC if X86_64 > + default UNWINDER_FRAME_POINTER if X86_32 > ---help--- > This determines which method will be used for unwinding kernel stack > traces for panics, oopses, bugs, warnings, perf, /proc//stack, > livepatch, lockdep, and more. > > -config UNWINDER_FRAME_POINTER > - bool "Frame pointer unwinder" > - select FRAME_POINTER > - ---help--- > - This option enables the frame pointer unwinder for unwinding kernel > - stack traces. > - > - The unwinder itself is fast and it uses less RAM than the ORC > - unwinder, but the kernel text size will grow by ~3% and the kernel's > - overall performance will degrade by roughly 5-10%. > - > - This option is recommended if you want to use the livepatch > - consistency model, as this is currently the only way to get a > - reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE). > - > config UNWINDER_ORC > bool "ORC unwinder" > depends on X86_64 > @@ -395,6 +381,21 @@ config UNWINDER_ORC > Enabling this option will increase the kernel's runtime memory usage > by roughly 2-4MB, depending on your kernel config. > > +config UNWINDER_FRAME_POINTER > + bool "Frame pointer unwinder" > + select FRAME_POINTER > + ---help--- > + This option enables the frame pointer unwinder for unwinding kernel > + stack traces. > + > + The unwinder itself is fast and it uses less RAM than the ORC > + unwinder, but the kernel text size will grow by ~3% and the kernel's > + overall performance will degrade by roughly 5-10%. > + > + This option is recommended if you want to use the livepatch > + consistency model, as this is currently the only way to get a > + reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE). > + > config UNWINDER_GUESS > bool "Guess unwinder" > depends on EXPERT