From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbdJSSGF (ORCPT ); Thu, 19 Oct 2017 14:06:05 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:49894 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbdJSSGD (ORCPT ); Thu, 19 Oct 2017 14:06:03 -0400 X-Google-Smtp-Source: ABhQp+RkcQYjTQX0kadcSZ8LxzWMn1LNxKMRmdto0fy8I99uugNd3DOIHvUhqCtGVNWBrw7oUMylWg== Date: Thu, 19 Oct 2017 20:06:00 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, Andy Lutomirski , quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, Greg KH , Alan Cox Subject: Re: [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Message-ID: <20171019180600.6gp7ch3z3bgbkqwt@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 19 October 2017 12:50:08 Mario Limonciello wrote: > + priv->interface_version = buffer[2]; > + priv->size = buffer[3]; > + ret = 0; > + dev_set_drvdata(&wdev->dev, priv); > + list_add_tail(&priv->list, &wmi_list); Still missing lock when changing wmi_list. > + > + dev_dbg(&wdev->dev, "Detected Dell WMI interface version %lu and buffer size %lu\n", > + (unsigned long) priv->interface_version, > + (unsigned long) priv->size); > + > +out: > + kfree(obj); > + return ret; > +} -- Pali Rohár pali.rohar@gmail.com