From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753933AbdJSSPU convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 14:15:20 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:35233 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752724AbdJSSPS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 14:15:18 -0400
Date: Thu, 19 Oct 2017 20:15:05 +0200
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: kbuild test robot <fengguang.wu@intel.com>, kbuild-all@01.org,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: do not include rtmutex_common.h unconditionally
Message-ID: <20171019181505.gpjnwi2csdvy53vd@linutronix.de>
References: <201710180754.irSSdw3W%fengguang.wu@intel.com>
 <20171018041447.GF3521@linux.vnet.ibm.com>
 <20171018073209.7l4p3lloqiw4bm6y@linutronix.de>
 <20171018083436.mlbwx2zvakp54gbw@linutronix.de>
 <20171018153946.GH3521@linux.vnet.ibm.com>
 <20171018161621.3o7fljv4wl3geutv@linutronix.de>
 <20171018204259.GR3521@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20171018204259.GR3521@linux.vnet.ibm.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017-10-18 13:42:59 [-0700], Paul E. McKenney wrote:
> 
> Builds for me on x86 and 0day test robot hasn't complained, but might
> as well get it right.

So I checked you tree and there is this:

|$ git one bc2eecd7ecce40af43b6eb3d256b6076257df846
|bc2eecd7ecce ("futex: Allow for compiling out PI support")
|$ git describe bc2eecd7ecce40af43b6eb3d256b6076257df846 --contains
|v4.14-rc1~162^2~57

so this exploded on my side because I applied it on top of v3.13, you on
the other hand had it post v4.13-rc1 so it was all good.
Now, that it is possible to include that header file with and without
CONFIG_RT_MUTEX=y we could indeed move that include outside of that
ifdef. Sorry for that.
We could do that and move the two defines (rt_mutex_owner +
rt_mutex_futex_unlock) to the rtmutex_common.h like in bc2eecd7ecce.
This might look good, I don't know. If you want, I can prepare a patch
for that, we could leave it as it…

>                        The new commits are:
> 
> a06f537e75ea ("rcu: do not include rtmutex_common.h unconditionally")
> 4a0fb5d70bb2 ("rcu: Suppress lockdep false-positive ->boost_mtx complaints")

Okay, thanks.

> 							Thanx, Paul

Sebastian