mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Chao Yu <chao@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: return error number for quota_write
Date: Thu, 19 Oct 2017 12:08:51 -0700	[thread overview]
Message-ID: <20171019190851.GB82186@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <f7c99fe2-5920-1274-a6c2-0cc831b8aca3@huawei.com>

On 10/18, Chao Yu wrote:
> On 2017/10/18 2:17, Jaegeuk Kim wrote:
> > On 10/17, Chao Yu wrote:
> >>
> >>
> >> On 2017/10/17 7:04, Jaegeuk Kim wrote:
> >>> On 10/16, Chao Yu wrote:
> >>>> Hi Jaegeuk,
> >>>>
> >>>> On 2017/10/13 7:15, Jaegeuk Kim wrote:
> >>>>> This patch returns an error number to quota_write in order for quota to handle
> >>>>> it correctly.
> >>>>
> >>>> We should return error number like __generic_file_write_iter, right? it
> >>>> needs to return written bytes if we have written one page or more, otherwise
> >>>> return error number feedbacked from write_begin.
> >>>>
> >>>> So how about reverting 4f31d26b0c17 ("f2fs: return wrong error number on
> >>>> f2fs_quota_write")?
> >>>
> >>> I thought like that, but realized the code change is somewhat different between
> >>> them.
> >>
> >> Hmm... main structure of codes here is copied from other file systems, is there
> >> the same problem in *_quota_write of other file systems?
> >>
> >> BTW, it looks making below judgment condition being useless.
> >>
> >> 	if (len == towrite)
> >> 		return 0;
> > 
> > We need this to avoid needless inode updates. :P
> 
> For err = 0 and len == towrite case, it more likes a bug of quota that passing
> 0 in @len.
> 
> :(, Oh, still didn't get that why there is difference in between reverting and
> this fixing. Can you please explain more about this?

Ah, right. Let me just revert the original patch. :)

Thanks,

  reply	other threads:[~2017-10-19 19:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 23:15 Jaegeuk Kim
2017-10-16  1:52 ` Chao Yu
2017-10-16 23:04   ` Jaegeuk Kim
2017-10-17 13:12     ` [f2fs-dev] " Chao Yu
2017-10-17 18:17       ` Jaegeuk Kim
2017-10-18  2:13         ` Chao Yu
2017-10-19 19:08           ` Jaegeuk Kim [this message]
2017-10-22 15:01             ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019190851.GB82186@jaegeuk-macbookpro.roam.corp.google.com \
    --to=jaegeuk@kernel.org \
    --cc=chao@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®