From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbdJSXAk (ORCPT ); Thu, 19 Oct 2017 19:00:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32659 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdJSXAj (ORCPT ); Thu, 19 Oct 2017 19:00:39 -0400 From: Mike Kravetz To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Naoya Horiguchi , Michal Hocko , Aneesh Kumar , Anshuman Khandual , Andrew Morton , Mike Kravetz Subject: [PATCH 0/1] mm:hugetlbfs: Fix hwpoison reserve accounting Date: Thu, 19 Oct 2017 16:00:06 -0700 Message-Id: <20171019230007.17043-1-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.13.6 X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The routine hugetlbfs_error_remove_page() incorrectly calls hugetlb_fix_reserve_counts which will result in bad (negative) reserved huge page counts. The following patch addresses this issue. A follow up question/issue: When a hugetlbfs page is poisoned, it appears as an 'in use' huge page via all the external user visible metrics. Even the in internal counters think this is simply an 'in use' huge page. This usually is not an issue. However, it may be confusing if someone adjusts the total number of huge pages. For example, if after poisoning a huge page I set the total number of huge pages to zero, the poisoned page will be counted as 'surplus'. I was thinking about keeping at least a bad page count (if not a list) to avoid user confusion. It may be overkill as I have not given too much thought to this issue. Anyone else have thoughts here? Mike Kravetz (1): mm:hugetlbfs: Fix hwpoison reserve accounting fs/hugetlbfs/inode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.13.6