From: David Miller <davem@davemloft.net>
To: mgamal@redhat.com
Cc: netdev@vger.kernel.org, skhare@vmware.com, pv-drivers@vmware.com,
linux-kernel@vger.kernel.org, cavery@redhat.com,
otubo@redhat.com, vkuznets@redhat.com
Subject: Re: [PATCH] vmxnet3: Use correct minimum MTU value
Date: Fri, 20 Oct 2017 07:15:48 +0100 (WEST) [thread overview]
Message-ID: <20171020.071548.524144466372098011.davem@davemloft.net> (raw)
In-Reply-To: <1508250823-1954-1-git-send-email-mgamal@redhat.com>
From: Mohammed Gamal <mgamal@redhat.com>
Date: Tue, 17 Oct 2017 16:33:43 +0200
> Currently the vmxnet3 driver has a minimum MTU value of 60. Which
> goes against the RFC791 spec which specifies it at 68.
>
> Setting MTU to values between 60 <= MTU <= 67 causes the network
> interface to lose its IP, and it fails to restart.
>
> This sets the minimum value to ETH_MIN_MTU (68) which is compatible
> with is according to spec.
>
> Reported-by: Bo Yang <boyang@redhat.com>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
There are protocols other than IPv4, and as Andrew mentioned
the ipv4 stack does the right thing by disabling ipv4 on
an interface when the MTU is too small.
prev parent reply other threads:[~2017-10-20 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:33 Mohammed Gamal
2017-10-18 7:15 ` Andrew Lunn
2017-10-20 6:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020.071548.524144466372098011.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cavery@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®