From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdJTHg3 (ORCPT ); Fri, 20 Oct 2017 03:36:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34018 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbdJTHg1 (ORCPT ); Fri, 20 Oct 2017 03:36:27 -0400 Date: Fri, 20 Oct 2017 08:36:23 +0100 (WEST) Message-Id: <20171020.083623.347659428573746599.davem@davemloft.net> To: arnd@arndb.de Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: sched: cls_u32: use hash_ptr() for tc_u_hash From: David Miller In-Reply-To: <20171018083403.3236142-1-arnd@arndb.de> References: <20171018083403.3236142-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Oct 2017 00:36:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 18 Oct 2017 10:33:37 +0200 > After the change to the tp hash, we now get a build warning > on 32-bit architectures: > > net/sched/cls_u32.c: In function 'tc_u_hash': > net/sched/cls_u32.c:338:17: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > return hash_64((u64) tp->chain->block, U32_HASH_SHIFT); > > Using hash_ptr() instead of hash_64() lets us drop the cast > and fixes the warning while still resulting in the same hash > value. > > Fixes: 7fa9d974f3c2 ("net: sched: cls_u32: use block instead of q in tc_u_common") > Signed-off-by: Arnd Bergmann Applied.