From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbdJTJa4 (ORCPT ); Fri, 20 Oct 2017 05:30:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:9840 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbdJTJay (ORCPT ); Fri, 20 Oct 2017 05:30:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,405,1503385200"; d="scan'208";a="911862505" Date: Fri, 20 Oct 2017 12:29:50 +0300 From: "Kirill A. Shutemov" To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , David Rientjes , Arnd Bergmann , Hugh Dickins , =?iso-8859-1?B?Suly9G1l?= Glisse , Daniel Colascione , Zi Yan , Naoya Horiguchi Subject: Re: [PATCH -mm -V2] mm, pagemap: Fix soft dirty marking for PMD migration entry Message-ID: <20171020092950.uikxca6ign4ydpjt@black.fi.intel.com> References: <20171019151046.3443-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171019151046.3443-1-ying.huang@intel.com> User-Agent: NeoMutt/20170714-126-deb55f (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 03:10:46PM +0000, Huang, Ying wrote: > From: Huang Ying > > Now, when the page table is walked in the implementation of > /proc//pagemap, pmd_soft_dirty() is used for both the PMD huge > page map and the PMD migration entries. That is wrong, > pmd_swp_soft_dirty() should be used for the PMD migration entries > instead because the different page table entry flag is used. > Otherwise, the soft dirty information in /proc//pagemap may be > wrong. > > Cc: Michal Hocko > Cc: "Kirill A. Shutemov" As I said before, you can use my ack for this. -- Kirill A. Shutemov