From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbdJTMDX (ORCPT ); Fri, 20 Oct 2017 08:03:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43166 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbdJTMDV (ORCPT ); Fri, 20 Oct 2017 08:03:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E3EA83F3F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Fri, 20 Oct 2017 07:03:18 -0500 From: Josh Poimboeuf To: Miroslav Benes Cc: Joao Moreira , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, mmarek@suse.cz, pmladek@suse.com, jikos@suse.cz, nstange@suse.de, jroedel@suse.de, matz@suse.de, khlebnikov@yandex-team.ru, jeyu@kernel.org Subject: Re: [PATCH 0/8] livepatch: klp-convert tool Message-ID: <20171020120318.ly2ym7a34vhn7zmx@treble> References: <20171011024615.y55lwbgpgo6b5dll@treble> <14124e34-04f7-950e-72fb-64f13e62f57e@suse.de> <20171019130146.uxjuhgn2t3yavgz2@treble> <20171019140338.pngwewyzllaw2wu5@treble> <20171019151522.5ih3egvzr3wm3h7r@treble> <20171019162001.4y3lb3eqsucop6x4@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 20 Oct 2017 12:03:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2017 at 10:51:40AM +0200, Miroslav Benes wrote: > > But with klp-convert, there's no such documentation, because there's no > > safe way to use it without other supplementary tooling which doesn't > > exist. > > True. > > I don't know if I mentioned it before. There is -fdump-ipa-clones now in > GCC for dumping every clone operation GCC does. > > https://github.com/marxin/kgraft-analysis-tool processes the dump and > extracts useful information for a symbol. Thanks, that looks really nice. I see that my GCC 7 has -fdump-ipa-clones. It would be great if we could integrate that script's functionality with klp-convert somehow, such that it would warn if you're patching a function or a relocation which is affected. Or at least document how a human could do so. -- Josh