From: Greg KH <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/12] nvmem: mtk-efuse: use stack for nvmem_config instead of malloc'ing it
Date: Fri, 20 Oct 2017 15:54:23 +0200 [thread overview]
Message-ID: <20171020135423.GC20327@kroah.com> (raw)
In-Reply-To: <CAK7LNATDZ2ngyOs=z7mjE6g95yWg2biNHMoFk29AgxgEEhn_+A@mail.gmail.com>
On Fri, Oct 20, 2017 at 10:47:28PM +0900, Masahiro Yamada wrote:
> 2017-10-20 22:34 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Mon, Oct 09, 2017 at 03:26:31PM +0200, srinivas.kandagatla@linaro.org wrote:
> >> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>
> >> nvmem_register() copies all the members of nvmem_config to
> >> nvmem_device. So, nvmem_config is one-time use data during
> >> probing. There is no point to keep it until the driver detach.
> >> Using stack should be no problem because nvmem_config is pretty
> >> small.
> >
> > Same objection as previous patch, what is wrong with it as-is?
> >
>
> It is wasting memory.
The memory is freed again, after the call, right?
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-20 13:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 13:26 [PATCH 00/12] nvmem: patches set-1 for v4.15 srinivas.kandagatla
2017-10-09 13:26 ` [PATCH 01/12] nvmem: imx-iim: use stack for nvmem_config instead of malloc'ing it srinivas.kandagatla
2017-10-20 13:32 ` Greg KH
2017-10-20 13:47 ` Masahiro Yamada
2017-10-20 13:54 ` Greg KH
2017-10-20 14:26 ` Masahiro Yamada
2017-10-20 14:47 ` Greg KH
2017-10-20 16:18 ` Masahiro Yamada
2017-10-20 16:26 ` Greg KH
2017-10-30 15:55 ` Masahiro Yamada
2017-10-09 13:26 ` [PATCH 02/12] nvmem: mtk-efuse: " srinivas.kandagatla
2017-10-20 13:34 ` Greg KH
2017-10-20 13:47 ` Masahiro Yamada
2017-10-20 13:54 ` Greg KH [this message]
2017-10-20 13:59 ` Masahiro Yamada
2017-10-20 14:48 ` Greg KH
2017-10-09 13:26 ` [PATCH 03/12] nvmem: mtk-efuse: fix different address space warnings of sparse srinivas.kandagatla
2017-10-20 13:34 ` Greg KH
2017-10-20 13:55 ` Masahiro Yamada
2017-10-20 14:49 ` Greg KH
2017-10-20 16:08 ` Masahiro Yamada
2017-10-09 13:26 ` [PATCH 04/12] nvmem: qfprom: " srinivas.kandagatla
2017-10-20 13:34 ` Greg KH
2017-10-09 13:26 ` [PATCH 05/12] nvmem: set nvmem->owner to nvmem->dev->driver->owner if unset srinivas.kandagatla
2017-10-20 13:38 ` Greg KH
2017-10-20 13:44 ` Srinivas Kandagatla
2017-10-20 13:52 ` Greg KH
2017-10-09 13:26 ` [PATCH 06/12] nvmem: sunxi-sid: add support for A64/H5's SID controller srinivas.kandagatla
2017-10-20 13:36 ` Greg KH
2017-10-09 13:26 ` [PATCH 07/12] dt-bindings: nvmem: add description for UniPhier eFuse srinivas.kandagatla
2017-10-20 13:36 ` Greg KH
2017-10-09 13:26 ` [PATCH 08/12] nvmem: uniphier: add UniPhier eFuse driver srinivas.kandagatla
2017-10-20 13:37 ` Greg KH
2017-10-09 13:26 ` [PATCH 09/12] nvmem: rockchip: add support for RK3368 srinivas.kandagatla
2017-10-09 13:26 ` [PATCH 10/12] dt-bindings: nvmem: Describe the Amlogic Meson6/Meson8/Meson8b efuse srinivas.kandagatla
2017-10-12 20:52 ` Martin Blumenstingl
2017-10-09 13:26 ` [PATCH 11/12] nvmem: meson-efuse: indicate that this driver is only for Meson GX SoCs srinivas.kandagatla
2017-10-12 20:51 ` Martin Blumenstingl
2017-10-09 13:26 ` [PATCH 12/12] nvmem: add a driver for the Amlogic Meson6/Meson8/Meson8b SoCs srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020135423.GC20327@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome