From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: [rcu:rcu/alpha 1/19] arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely'
Date: Fri, 20 Oct 2017 09:51:15 -0700 [thread overview]
Message-ID: <20171020165115.GL3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171020164321.GB7287@arm.com>
On Fri, Oct 20, 2017 at 05:43:22PM +0100, Will Deacon wrote:
> On Fri, Oct 20, 2017 at 09:39:07AM -0700, Paul E. McKenney wrote:
> > On Fri, Oct 20, 2017 at 10:36:37AM +0100, Will Deacon wrote:
> > > On Fri, Oct 20, 2017 at 05:17:54AM +0800, kbuild test robot wrote:
> > > > In file included from arch/sparc/include/asm/processor_64.h:18:0,
> > > > from arch/sparc/include/asm/processor.h:4,
> > > > from include/linux/prefetch.h:14,
> > > > from drivers/net/ethernet/emulex/benet/be_main.c:18:
> > > > arch/sparc/include/asm/ptrace.h: In function 'regs_get_register':
> > > > >> arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely' [-Werror=implicit-function-declaration]
> > > > if (unlikely(offset >= MAX_REG_OFFSET))
> > > > ^~~~~~~~
> > > > cc1: some warnings being treated as errors
> > >
> > > I'm not sure why I didn't get these reports from my tree, but there's a
> > > fixup patch below.
> >
> > There is some RANDCONFIG action in kbuild test robot, so your mileage
> > can vary. Thank you for the fix, please see below.
>
> True, I forgot about that.
>
> > > --->8
> > >
> > > >From db5984f0878a013857299acd7e0fa406905d973c Mon Sep 17 00:00:00 2001
> > > From: Will Deacon <will.deacon@arm.com>
> > > Date: Fri, 20 Oct 2017 10:21:18 +0100
> > > Subject: [PATCH] sparc64: ptrace: Include linux/compiler.h for unlikely()
> > >
> > > Compiler.g is no longer implicitly included in asm/ptrace.h so pull it
> > > in explicitly to get a definition for the unlikely() macro.
> > >
> > > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > > ---
> > > arch/sparc/include/asm/ptrace.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/sparc/include/asm/ptrace.h b/arch/sparc/include/asm/ptrace.h
> > > index d73428e4333c..b383484edcd3 100644
> > > --- a/arch/sparc/include/asm/ptrace.h
> > > +++ b/arch/sparc/include/asm/ptrace.h
> > > @@ -6,6 +6,7 @@
> > > #if defined(__sparc__) && defined(__arch64__)
> > > #ifndef __ASSEMBLY__
> > >
> > > +#include <linux/compiler.h>
> > > #include <linux/threads.h>
> > > #include <asm/switch_to.h>
> >
> > I folded this into your first commit ("linux/compiler.h: Split into
> > compiler.h and compiler-types.h") like so. Does that work for you?
>
> Yes, thanks! There's another fix for arch/um/ too (I replied to it this
> morning).
Apologies, I did apply them out of order. One of those mornings, I guess!
Thanx, Paul
prev parent reply other threads:[~2017-10-20 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 21:17 kbuild test robot
2017-10-20 9:36 ` Will Deacon
2017-10-20 16:39 ` Paul E. McKenney
2017-10-20 16:43 ` Will Deacon
2017-10-20 16:51 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020165115.GL3521@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome