From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753750AbdJTRlN (ORCPT ); Fri, 20 Oct 2017 13:41:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:54266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753729AbdJTRlL (ORCPT ); Fri, 20 Oct 2017 13:41:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78977218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Fri, 20 Oct 2017 12:41:08 -0500 From: Bjorn Helgaas To: Pankaj Dubey Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Joao Pinto Subject: Re: [PATCH] PCI: designware: move dw_pcie_iatu_unroll_enabled to pcie-designware.c Message-ID: <20171020174108.GK6332@bhelgaas-glaptop.roam.corp.google.com> References: <1507783268-9022-1-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507783268-9022-1-git-send-email-pankaj.dubey@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 10:11:08AM +0530, Pankaj Dubey wrote: > IATU unroll feature can be enabled in EP mode as well, so we need to > have this check in pcie-designware-ep.c, so instead of making this > function as static in pcie-desigware-host.c, let's move this in > pcie-designware.c so that both pcie-designware-host.c and > pcie-designware-ep.c can use it. > > Signed-off-by: Pankaj Dubey This is fine with me but I'm looking for an ack from Jingoo and/or Joao. > --- > drivers/pci/dwc/pcie-designware-ep.c | 4 ++++ > drivers/pci/dwc/pcie-designware-host.c | 11 ----------- > drivers/pci/dwc/pcie-designware.c | 11 +++++++++++ > drivers/pci/dwc/pcie-designware.h | 1 + > 4 files changed, 16 insertions(+), 11 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c > index d53d5f1..64803a9 100644 > --- a/drivers/pci/dwc/pcie-designware-ep.c > +++ b/drivers/pci/dwc/pcie-designware-ep.c > @@ -314,6 +314,10 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > if (ep->ops->ep_init) > ep->ops->ep_init(ep); > > + pci->iatu_unroll_enabled = dw_pcie_iatu_unroll_enabled(pci); > + dev_dbg(dev, "iATU unroll: %s\n", > + pci->iatu_unroll_enabled ? "enabled" : "disabled"); > + > epc = devm_pci_epc_create(dev, &epc_ops); > if (IS_ERR(epc)) { > dev_err(dev, "failed to create epc device\n"); > diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c > index 81e2157..d3f579e 100644 > --- a/drivers/pci/dwc/pcie-designware-host.c > +++ b/drivers/pci/dwc/pcie-designware-host.c > @@ -574,17 +574,6 @@ static struct pci_ops dw_pcie_ops = { > .write = dw_pcie_wr_conf, > }; > > -static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci) > -{ > - u32 val; > - > - val = dw_pcie_readl_dbi(pci, PCIE_ATU_VIEWPORT); > - if (val == 0xffffffff) > - return 1; > - > - return 0; > -} > - > void dw_pcie_setup_rc(struct pcie_port *pp) > { > u32 val; > diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c > index 88abddd..f15da90 100644 > --- a/drivers/pci/dwc/pcie-designware.c > +++ b/drivers/pci/dwc/pcie-designware.c > @@ -92,6 +92,17 @@ void __dw_pcie_write_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg, > dev_err(pci->dev, "write DBI address failed\n"); > } > > +u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci) I know this is just moved verbatim, but it's more conventional to simply return an int (or possibly bool) for a predicate like this. There's really no point in going out of your way to specify "u8" for the return type. > +{ > + u32 val; > + > + val = dw_pcie_readl_dbi(pci, PCIE_ATU_VIEWPORT); > + if (val == 0xffffffff) > + return 1; > + > + return 0; > +} > + > static u32 dw_pcie_readl_ob_unroll(struct dw_pcie *pci, u32 index, u32 reg) > { > u32 offset = PCIE_GET_ATU_OUTB_UNR_REG_OFFSET(index); > diff --git a/drivers/pci/dwc/pcie-designware.h b/drivers/pci/dwc/pcie-designware.h > index e5d9d77..8d6829c 100644 > --- a/drivers/pci/dwc/pcie-designware.h > +++ b/drivers/pci/dwc/pcie-designware.h > @@ -242,6 +242,7 @@ int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int index, int bar, > void dw_pcie_disable_atu(struct dw_pcie *pci, int index, > enum dw_pcie_region_type type); > void dw_pcie_setup(struct dw_pcie *pci); > +u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci); > > static inline void dw_pcie_writel_dbi(struct dw_pcie *pci, u32 reg, u32 val) > { > -- > 2.7.4 >