From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbdJUA5W (ORCPT ); Fri, 20 Oct 2017 20:57:22 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45986 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbdJUA5U (ORCPT ); Fri, 20 Oct 2017 20:57:20 -0400 Date: Sat, 21 Oct 2017 01:57:17 +0100 (WEST) Message-Id: <20171021.015717.969519862483319323.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, gwshan@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout From: David Miller In-Reply-To: <20171019024309.13628-4-sam@mendozajonas.com> References: <20171019024309.13628-1-sam@mendozajonas.com> <20171019024309.13628-4-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Oct 2017 17:57:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:08 +1100 > From: Gavin Shan > > The NCSI channel has been configured to provide service if its link > monitor timer is enabled, regardless of its state (inactive or active). > So the timeout event on the link monitor indicates the out-of-service > on that channel, for which a failover is needed. > > This sets NCSI_DEV_RESHUFFLE flag to enforce failover on link monitor > timeout, regardless the channel's original state (inactive or active). > Also, the link is put into "down" state to give the failing channel > lowest priority when selecting for the active channel. The state of > failing channel should be set to active in order for deinitialization > and failover to be done. > > Signed-off-by: Gavin Shan > Signed-off-by: Samuel Mendoza-Jonas Applied.