From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdJVLMY (ORCPT ); Sun, 22 Oct 2017 07:12:24 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59004 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdJVLMX (ORCPT ); Sun, 22 Oct 2017 07:12:23 -0400 Date: Sun, 22 Oct 2017 13:12:10 +0200 From: Borislav Petkov To: Ingo Molnar Cc: X86 ML , Sherry Hurwitz , Yazen Ghannam , mirh@protonmail.ch, LKML Subject: Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't Message-ID: <20171022111210.2bizzpjim7dyjhdz@pd.tnic> References: <20171022104731.28249-1-bp@alien8.de> <20171022110438.jt3erskmxrvz52us@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171022110438.jt3erskmxrvz52us@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > Any objections to me adding a printk message that we applied a fix? > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > or so? > > That would also create some pressure for customers to prod manufacturers to prod > BIOS makers to fix the erratum in a BIOS update or so. Adding that would be purely useless because F14h is long out of production AFAIK. Especially those earlier models. So getting new BIOS for those is less likely than winning the lottery. IOW, this is more or less, an after-the-fact fix for the remaining machines out there. Note that I didn't even use a bug flag because it would simply be a waste. Frankly, this fix could simply be a userspace script setting those two MSR bits but then communicating it to people would be a nightmare, thus the kernel fix. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.