From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbdJWCMx (ORCPT ); Sun, 22 Oct 2017 22:12:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:40508 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbdJWCMv (ORCPT ); Sun, 22 Oct 2017 22:12:51 -0400 Date: Mon, 23 Oct 2017 03:12:47 +0100 (WEST) Message-Id: <20171023.031247.1142312234606249877.davem@davemloft.net> To: keescook@chromium.org Cc: pebolle@tiscali.nl, isdn@linux-pingi.de, johan@kernel.org, linux-kernel@vger.kernel.org, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH] isdn/gigaset: Provide cardstate context for bas timer callbacks From: David Miller In-Reply-To: <20171020204708.GA58150@beast> References: <20171020204708.GA58150@beast> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 22 Oct 2017 19:12:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Fri, 20 Oct 2017 13:47:08 -0700 > While the work callback uses the urb to find cardstate from bas_cardstate, > this may not be valid for timer callbacks. Instead, introduce a direct > pointer back to the cardstate from bas_cardstate for use in timer > callbacks. > > Reported-by: Paul Bolle > Fixes: 4cfea08e6251 ("isdn/gigaset: Convert timers to use timer_setup()") > Cc: Paul Bolle > Cc: Karsten Keil > Cc: "David S. Miller" > Cc: Johan Hovold > Cc: gigaset307x-common@lists.sourceforge.net > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Applied to net-next.