From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751295AbdJWJKr (ORCPT ); Mon, 23 Oct 2017 05:10:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37885 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdJWJKp (ORCPT ); Mon, 23 Oct 2017 05:10:45 -0400 Date: Mon, 23 Oct 2017 12:10:24 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: user-mode-linux-devel@lists.sourceforge.net, Jeff Dike , Richard Weinberger , user-mode-linux-user@lists.sourceforge.net, kernel-janitors@vger.kernel.org, LKML Subject: Re: um: Use common error handling code in port_listen_fd() Message-ID: <20171023091024.yxfva5p63zodj6bp@mwanda> References: <20171023084800.p26qcpb7iqyqrz4v@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2017 at 11:01:05AM +0200, SF Markus Elfring wrote: > > This business of moving the error code to the bottom of the function > > just makes the code less readable. > > I got an other software development opinion on this aspect. > Could you become used to the proposed control flow structure > in the affected function? > No. Don't do this. It's pointless obfuscation. > > > I know you never listen to anyone, > > My response times might not fir to your preferences. > > > > but you should stop doing it. > > I am going to offer suggestions for change patterns which I find useful. > There are some challenges around change acceptance as usual. Yeah. I knew it was pointless to ask you to stop this... :( regards, dan carpenter