From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbdJWLcF (ORCPT ); Mon, 23 Oct 2017 07:32:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:45340 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbdJWLcE (ORCPT ); Mon, 23 Oct 2017 07:32:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,422,1503385200"; d="scan'208";a="165889093" From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org Cc: linux-security-module@vger.kernel.org, Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net (moderated list:TPM DEVICE DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] tpm: remove a misleading error message from tpm_get_timeouts() Date: Mon, 23 Oct 2017 13:31:55 +0200 Message-Id: <20171023113155.12921-1-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tpm_transmit_cmd() takes care of printing a TPM error whereas the print statement in tpm_get_timeouts() either duplicates its behavior or prints a system error code still saying that it is a TPM error code. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index ebe0a1d36d8c..d8e2e5bca903 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -664,13 +664,6 @@ int tpm_get_timeouts(struct tpm_chip *chip) sizeof(cap.timeout)); } - if (rc) { - dev_err(&chip->dev, - "A TPM error (%zd) occurred attempting to determine the timeouts\n", - rc); - return rc; - } - timeout_old[0] = jiffies_to_usecs(chip->timeout_a); timeout_old[1] = jiffies_to_usecs(chip->timeout_b); timeout_old[2] = jiffies_to_usecs(chip->timeout_c); -- 2.14.1