Re: [PATCH RESEND v3 2/2] mfd: fsl-imx25: clean up irq settings during removal

[Lee Jones <lee.jones@linaro.org>]

On Tue, 17 Oct 2017, Martin Kaiser wrote:

> When fsl-imx25-tsadc is compiled as a module, loading, unloading and
> reloading the module will lead to a crash.
> 
> Unable to handle kernel paging request at virtual address bf005430
> [<c004df6c>] (irq_find_matching_fwspec)
>    from [<c028d5ec>] (of_irq_get+0x58/0x74)
> [<c028d594>] (of_irq_get)
>    from [<c01ff970>] (platform_get_irq+0x48/0xc8)
> [<c01ff928>] (platform_get_irq)
>    from [<bf00e33c>] (mx25_tsadc_probe+0x220/0x2f4 [fsl_imx25_tsadc])
> 
> irq_find_matching_fwspec() loops over all registered irq domains. The
> irq domain is still registered from last time the module was loaded but
> the pointer to its operations is invalid after the module was unloaded.
> 
> Add a removal function which clears the irq handler and removes the irq
> domain. With this cleanup in place, it's possible to unload and reload
> the module.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Hello Lee,
> 
> thanks for merging the first patch of this series. Any chance you can
> have a look at this one as well? Please let me know if you want me to
> make any changes.
> 
> Best regards,
> Martin 
> 
> changes in v3:
>  delete__exit qualifier from the remove routine
> 
> changes in v2:
>  add more details about the crash to the commit message
> 
>  drivers/mfd/fsl-imx25-tsadc.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog