From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbdJWPny (ORCPT ); Mon, 23 Oct 2017 11:43:54 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:56078 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbdJWPnx (ORCPT ); Mon, 23 Oct 2017 11:43:53 -0400 X-Google-Smtp-Source: ABhQp+RS7e/cqez7xQq8D1Ji23yu0UURq2UB7Eo8okvsBG0vye+jGtJUJNblgoLWIyhgxfaeRB3EXw== Date: Mon, 23 Oct 2017 16:43:40 +0100 From: Lee Jones To: Marek Szyprowski Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, MyungJoo Ham , Chanwoo Choi , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 1/2] extcon: max77843: Add OTG power control to the MUIC driver Message-ID: <20171023154340.z2vmkbfoey2xtgks@dell> References: <20171018095622.23738-1-m.szyprowski@samsung.com> <20171018095622.23738-2-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171018095622.23738-2-m.szyprowski@samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Oct 2017, Marek Szyprowski wrote: > Enabling power on VBUS micro-usb pin is required only when passive OTG > cable is connected. Initially OTG VBUS power control was planned to be > done in charger driver. However such information is not really available > from the extcon notifications, so VBUS power control has to be done > directly in MUIC driver, which has all information about the attached > accessory. > > For example SmartDock is externally powered accessory, provides OTG > (USB HOST) functionality and use VBUS pin for charging a device battery, > so the VBUS charging pump should be disabled in such case. > > Signed-off-by: Marek Szyprowski > Acked-by: Chanwoo Choi > --- > drivers/extcon/extcon-max77843.c | 16 ++++++++++++++++ > include/linux/mfd/max77843-private.h | 3 +++ Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog