From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbdJWPqD (ORCPT ); Mon, 23 Oct 2017 11:46:03 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:49196 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932274AbdJWPqA (ORCPT ); Mon, 23 Oct 2017 11:46:00 -0400 X-Google-Smtp-Source: ABhQp+Qyoo/WaIVF/Q3YpChsll5r7yEy+rXqPqOZgsdQA+aOtnZxtza+tbF+kp4bTmSIYx0+Idb7LQ== Date: Mon, 23 Oct 2017 16:45:40 +0100 From: Lee Jones To: sathyanarayanan.kuppuswamy@linux.intel.com Cc: a.zummo@towertech.it, x86@kernel.org, wim@iguana.be, mingo@redhat.com, alexandre.belloni@free-electrons.com, qipeng.zha@intel.com, hpa@zytor.com, dvhart@infradead.org, tglx@linutronix.de, andy@infradead.org, souvik.k.chakravarty@intel.com, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com Subject: Re: [RFC v6 8/9] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls Message-ID: <20171023154540.tdl7u4ntmeljybhx@dell> References: <491e7ea183ada1e50ac4ece6ca3f73ccda9cd42e.1508368279.git.sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <491e7ea183ada1e50ac4ece6ca3f73ccda9cd42e.1508368279.git.sathyanarayanan.kuppuswamy@linux.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Oct 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Removed redundant IPC helper functions and refactored the driver to use > generic IPC device driver APIs. Also, cleaned up the driver to minimize > the usage of global variable ipcdev by propogating the struct > intel_pmc_ipc_dev pointer or by getting it from device private data. > > This patch also cleans-up PMC IPC user drivers(intel_telemetry_pltdrv.c, > intel_soc_pmic_bxtwc.c) to use APIs provided by generic IPC driver. > > Signed-off-by: Kuppuswamy Sathyanarayanan > --- > arch/x86/include/asm/intel_pmc_ipc.h | 31 +- > drivers/mfd/intel_soc_pmic_bxtwc.c | 37 ++- > drivers/platform/x86/intel_pmc_ipc.c | 393 ++++++++++---------------- > drivers/platform/x86/intel_telemetry_pltdrv.c | 128 ++++----- > include/linux/mfd/intel_soc_pmic.h | 2 + Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog