From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbdJWQHl (ORCPT ); Mon, 23 Oct 2017 12:07:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:52597 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdJWQHk (ORCPT ); Mon, 23 Oct 2017 12:07:40 -0400 X-Google-Smtp-Source: ABhQp+T9guL0Y6K4vZQ8et+j3f4TB/OYVQKfY7sid3VAFRWkdmXzbLcKeEuOLgqkdLsNB5R8PutRXg== Date: Mon, 23 Oct 2017 17:07:26 +0100 From: Lee Jones To: Romain Izard Cc: Alexandre Belloni , Nicolas Ferre , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5] atmel_flexcom: Support backup mode Message-ID: <20171023160726.ufs37iyuicirwk4f@dell> References: <20171019164443.487-1-romain.izard.pro@gmail.com> <20171023160600.kcjy4ejdllllu62y@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171023160600.kcjy4ejdllllu62y@dell> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Oct 2017, Lee Jones wrote: > On Thu, 19 Oct 2017, Romain Izard wrote: > > > The controller used by a flexcom module is configured at boot, and left > > alone after this. As the configuration will be lost after backup mode, > > restore the state of the flexcom driver on resume. > > > > Signed-off-by: Romain Izard > > Acked-by: Nicolas Ferre > > Tested-by: Nicolas Ferre > > --- > > Changes in v5: > > * extract from the patch series, and send as a standalone patch > > > > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++----------- > > 1 file changed, 50 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c > > index 064bde9cff5a..ef1235c4a179 100644 > > --- a/drivers/mfd/atmel-flexcom.c > > +++ b/drivers/mfd/atmel-flexcom.c > > @@ -39,34 +39,44 @@ > > #define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \ > > FLEX_MR_OPMODE_MASK) > > > > +struct atmel_flexcom { > > + void __iomem *base; > > + u32 opmode; > > + struct clk *clk; > > +}; > > > > static int atmel_flexcom_probe(struct platform_device *pdev) > > { > > struct device_node *np = pdev->dev.of_node; > > - struct clk *clk; > > struct resource *res; > > - void __iomem *base; > > - u32 opmode; > > + struct atmel_flexcom *afc; > > Nit: I'd prefer if you call this 'ddata'. > > But the concept and implementation is fine, so if you're going to > change it please do so and apply my: > > Acked-by: Lee Jones Also, 'back-up mode' isn't really a thing is it? How about "Reinstall state on resume" or similar? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog