From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbdJWXpB (ORCPT ); Mon, 23 Oct 2017 19:45:01 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:50006 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdJWXo6 (ORCPT ); Mon, 23 Oct 2017 19:44:58 -0400 X-Google-Smtp-Source: ABhQp+TzwJL65aIODL/lSEO+/HvF3soLAVPfQYIRMwkV4Nh/H5zutJl7dOvxWzUznnVDhiP5VG4UZQ== Date: Mon, 23 Oct 2017 16:44:47 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Danilo Krummrich , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs Message-ID: <20171023234447.qaohcuyfvnwn5m2n@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We've been missing a goto to the unwind path... Signed-off-by: Dmitry Torokhov --- drivers/input/serio/ps2-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c index b50e3817f3c4..c62cceb97bb1 100644 --- a/drivers/input/serio/ps2-gpio.c +++ b/drivers/input/serio/ps2-gpio.c @@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device *pdev) gpiod_cansleep(drvdata->gpio_clk)) { dev_err(dev, "GPIO data or clk are connected via slow bus\n"); error = -EINVAL; + goto err_free_serio; } drvdata->irq = platform_get_irq(pdev, 0); -- 2.15.0.rc0.271.g36b669edcc-goog -- Dmitry