From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932427AbdJXIrd (ORCPT ); Tue, 24 Oct 2017 04:47:33 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbdJXIr0 (ORCPT ); Tue, 24 Oct 2017 04:47:26 -0400 Date: Tue, 24 Oct 2017 17:47:22 +0900 (KST) Message-Id: <20171024.174722.1655125725592115397.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: garsilva@embeddedor.com, steffen.klassert@secunet.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG From: David Miller In-Reply-To: <20171024032508.GC28462@gondor.apana.org.au> References: <20171023181857.GA25379@embeddedor.com> <20171024032508.GC28462@gondor.apana.org.au> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Oct 2017 01:47:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Tue, 24 Oct 2017 11:25:08 +0800 > On Mon, Oct 23, 2017 at 01:18:57PM -0500, Gustavo A. R. Silva wrote: >> Use BUG_ON instead of if condition followed by BUG. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > I think this patch is terrible. Why on earth is Coccinelle even > warning about this? BUG_ON(x) generates significantly better code than "if (cond) BUG();" because it's not possible to emit the most optimal code sequences like on powerpc that has conditional traps. That's why. I'm applying these transformations all over the networking as I receive them and I advise that you do so for crypto as well. Thank.